[dpdk-test-report] |WARNING| pw22966 [PATCH v2 3/5] add new xstats API id support for ixgbe

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22966

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#33: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:194:
+		uint64_t *values, unsigned n);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#43: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:204:
+	unsigned limit);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#67: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3110:
+	unsigned limit)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#70: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3113:
+		const unsigned cnt_stats = ixgbe_xstats_calc_num();

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#71: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3114:
+		unsigned stat, i, count;

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#122: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3165:
+	}
+	else {

CHECK:BRACES: Unbalanced braces around else statement
#122: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3165:
+	else {

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#132: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3175:
+				printf("ERROR: id value isn't valid 
");

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#151: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3277:
+		uint64_t *values, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#162: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3288:
+		unsigned i, stat, count = 0;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#180: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3306:
+		if (!ids && !values) {
+			return 0;
+		}

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#221: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3347:
+	}
+	else {

CHECK:BRACES: Unbalanced braces around else statement
#221: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3347:
+	else {

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#230: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3356:
+				printf("ERROR: id value isn't valid 
");

total: 2 errors, 10 warnings, 2 checks, 211 lines checked