[dpdk-test-report] |WARNING| pw24312 [PATCH v2 16/20] net/dpaa2: add support for flow control

checkpatch at dpdk.org checkpatch at dpdk.org
Mon May 15 14:39:57 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24312

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cfg' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cfg' may be better as '(cfg)' to avoid precedence issues
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 235 lines checked


More information about the test-report mailing list