[dpdk-test-report] |WARNING| pw31280 [PATCH RFC 1/2] lib: introduce raw device library

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Nov 8 18:42:01 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31280

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxB)
#1318: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:60:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1319: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:61:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1324: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:66:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1325: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:67:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1331: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:73:
+#define RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1338: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:80:
+#define RTE_RAWDEV_VALID_DEVID_OR_RET(dev_id) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return; \
+	} \
+} while (0)

total: 4 errors, 2 warnings, 1771 lines checked


More information about the test-report mailing list