[dpdk-test-report] |WARNING| pw31390 [PATCH 04/53] net/sfc/base: simplify verify result handling

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Nov 16 09:05:17 CET 2017

Previous message: [dpdk-test-report] |FAILURE| pw31389 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Re: [PATCH] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage Hi On Wed Nov 15 2017 at 12:46:15PM +0000 Hanoch Haim (hhaim) wrote: > +Oliver > Ilia I assume there is a reason why Oliver did that I just consolidate the code. > He didn't want to *write* the same value to mbuf field. > In the common case that pointer was already cleared by the driver it is better to just read it. From cache synchronization perspective it will run faster. > > Thanks > Hanoh > > > -----Original Message----- >
Next message: [dpdk-test-report] |SUCCESS| pw31391 [PATCH 02/53] net/sfc/base: do not use Tx desc push with TSO descriptors
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31390

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_fw_verified_nvram_update_required'
#56: FILE: drivers/net/sfc/base/efx_nvram.c:959:
+	if ((encp->enc_fw_verified_nvram_update_required) &&
+	    (result != MC_CMD_NVRAM_VERIFY_RC_SUCCESS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'result != MC_CMD_NVRAM_VERIFY_RC_SUCCESS'
#56: FILE: drivers/net/sfc/base/efx_nvram.c:959:
+	if ((encp->enc_fw_verified_nvram_update_required) &&
+	    (result != MC_CMD_NVRAM_VERIFY_RC_SUCCESS)) {

total: 0 errors, 0 warnings, 2 checks, 35 lines checked

More information about the test-report mailing list