[dpdk-test-report] |WARNING| pw29700 [PATCH v2 09/30] net/mlx5: add reference counter on memory region

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Oct 5 14:52:03 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29700

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#64: FILE: drivers/net/mlx5/mlx5.h:305:
+struct mlx5_mr *priv_mr_new(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#64: FILE: drivers/net/mlx5/mlx5.h:305:
+struct mlx5_mr *priv_mr_new(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#65: FILE: drivers/net/mlx5/mlx5.h:306:
+struct mlx5_mr *priv_mr_get(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#65: FILE: drivers/net/mlx5/mlx5.h:306:
+struct mlx5_mr *priv_mr_get(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#66: FILE: drivers/net/mlx5/mlx5.h:307:
+int priv_mr_release(struct priv *, struct mlx5_mr *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_mr *' should also have an identifier name
#66: FILE: drivers/net/mlx5/mlx5.h:307:
+int priv_mr_release(struct priv *, struct mlx5_mr *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#67: FILE: drivers/net/mlx5/mlx5.h:308:
+int priv_mr_verify(struct priv *);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'start > addr'
#238: FILE: drivers/net/mlx5/mlx5_mr.c:280:
+		if ((start > addr) && (start < addr + len))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end > addr'
#240: FILE: drivers/net/mlx5/mlx5_mr.c:282:
+		if ((end > addr) && (end < addr + len))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#310: FILE: drivers/net/mlx5/mlx5_mr.c:352:
+	return EBUSY;

total: 0 errors, 8 warnings, 2 checks, 436 lines checked


More information about the test-report mailing list