[dpdk-test-report] |WARNING| pw29975 [PATCH v3 20/30] net/mlx5: handle a single RSS hash key for all protocols

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 9 16:50:33 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29975

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=
 	     rss_hash_default_key_len'
#114: FILE: drivers/net/mlx5/mlx5_ethdev.c:581:
+	if (use_app_rss_key &&
+	    (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=
+	     rss_hash_default_key_len)) {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#118: FILE: drivers/net/mlx5/mlx5_ethdev.c:585:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#125: FILE: drivers/net/mlx5/mlx5_ethdev.c:592:
+		return ENOMEM;

total: 0 errors, 2 warnings, 1 checks, 270 lines checked


More information about the test-report mailing list