[dpdk-test-report] |WARNING| pw30498 [PATCH v2 1/5] bbdev: librte_bbdev library

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Oct 18 04:15:28 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30498

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#57: FILE: MAINTAINERS:279:
+M: Amr Mokhtar <amr.mokhtar at intel.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#58: FILE: MAINTAINERS:280:
+F: lib/librte_bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#59: FILE: MAINTAINERS:281:
+F: drivers/bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#60: FILE: MAINTAINERS:282:
+F: app/test-bbdev

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#61: FILE: MAINTAINERS:283:
+F: examples/bbdev_app/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#62: FILE: MAINTAINERS:284:
+F: doc/guides/bbdevs/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#63: FILE: MAINTAINERS:285:
+F: doc/guides/prog_guide/bbdev.rst

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#64: FILE: MAINTAINERS:286:
+F: doc/guides/sample_app_ug/bbdev_app.rst

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#65: FILE: MAINTAINERS:287:
+F: doc/guides/tools/testbbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#271: FILE: lib/librte_bbdev/rte_bbdev.c:59:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+	if (dev == NULL) { \
+		rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#279: FILE: lib/librte_bbdev/rte_bbdev.c:67:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+	if (dev->dev_ops == NULL) { \
+		rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+				dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#288: FILE: lib/librte_bbdev/rte_bbdev.c:76:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+	if (func == NULL) { \
+		rte_bbdev_log(ERR, "device %u does not support %s", \
+				dev_id, #func); \
+		return -ENOTSUP; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#297: FILE: lib/librte_bbdev/rte_bbdev.c:85:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+	if (queue_id >= dev->data->num_queues) { \
+		rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+				queue_id, dev->data->dev_id); \
+		return -ERANGE; \
+	} \
+} while (0)

WARNING:TYPO_SPELLING: 'INITALIZED' may be misspelled - perhaps 'INITIALIZED'?
#407: FILE: lib/librte_bbdev/rte_bbdev.c:195:
+	bbdev->state = RTE_BBDEV_INITALIZED;

WARNING:TYPO_SPELLING: 'INITALIZED' may be misspelled - perhaps 'INITIALIZED'?
#486: FILE: lib/librte_bbdev/rte_bbdev.c:274:
+			rte_bbdev_devices[dev_id].state == RTE_BBDEV_INITALIZED)

WARNING:TYPO_SPELLING: 'INITALIZED' may be misspelled - perhaps 'INITIALIZED'?
#1388: FILE: lib/librte_bbdev/rte_bbdev.h:75:
+	RTE_BBDEV_INITALIZED

total: 0 errors, 16 warnings, 3157 lines checked


More information about the test-report mailing list