[dpdk-test-report] |WARNING| pw28649 [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 13 12:16:16 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28649

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#249: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:203:
+ *  struct rte_event_eth_rx_adapter_conf struct passed into
+	 *    it.

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#250: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:204:
+	 *    it.
+ *

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#575: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:137:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) do { \
+	if (!valid_id(id)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1198: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:760:
+	if (conf->
+	    rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {

total: 0 errors, 4 warnings, 1663 lines checked


More information about the test-report mailing list