[dpdk-test-report] |WARNING| pw37281 [PATCH v3 20/21] net/virtio: add support for event suppression

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 5 12:13:20 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37281

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#57: FILE: drivers/net/virtio/virtio_rxtx.c:130:
+		if (unlikely(virtqueue_kick_prepare_packed(vq))) {
+				virtqueue_notify(vq);

CHECK:BRACES: braces {} should be used on all arms of this statement
#128: FILE: drivers/net/virtio/virtqueue.h:296:
+		if (*event_off_wrap & RING_EVENT_FLAGS_DESC) {
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#132: FILE: drivers/net/virtio/virtqueue.h:300:
+		} else

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#185: FILE: drivers/net/virtio/virtqueue.h:405:
+		new = vq->vq_signalled_avail = vq->vq_avail_idx;

total: 0 errors, 1 warnings, 3 checks, 154 lines checked


More information about the test-report mailing list