[dpdk-test-report] |WARNING| pw43931 [2/8] net/mvneta: add Rx/Tx support

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Aug 28 17:10:46 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43931

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#50: FILE: drivers/net/mvneta/mvneta_ethdev.c:59:
+#define MVNETA_SET_COOKIE_HIGH_ADDR(addr) {				\
+	if (unlikely(cookie_addr_high == MVNETA_COOKIE_ADDR_INVALID))	\
+		cookie_addr_high =					\
+			(uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK;	\
+}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#56: FILE: drivers/net/mvneta/mvneta_ethdev.c:65:
+#define MVNETA_CHECK_COOKIE_HIGH_ADDR(addr)			\
+	((likely(cookie_addr_high ==				\
+	((uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK))) ? 1 : 0)

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#336: FILE: drivers/net/mvneta/mvneta_ethdev.c:362:
+		rte_pktmbuf_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#707: FILE: drivers/net/mvneta/mvneta_ethdev.c:774:
+				bytes_sent -= rte_pktmbuf_pkt_len(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num != rxq->size'
#870: FILE: drivers/net/mvneta/mvneta_ethdev.c:1302:
+		if (ret || (num != rxq->size)) {

total: 0 errors, 0 warnings, 5 checks, 895 lines checked


More information about the test-report mailing list