[dpdk-test-report] |WARNING| pw35165 [PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf drv

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Feb 14 13:01:02 CET 2018

Test-Label: checkpatch
Test-Status: WARNING

_coding style issues_

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
The check for bool was accounting unwanted bits in the calulation of truth value. In dpdk unsingned int is typedefed to bool but all it cares about is Least Significant Bit. But in calculation of condition expression the bits other than LSB was used which doesn't make sense. Some time these bits has values which results in to incorrect expression results. To fix this we just need to account LSB form the bool value . This can be easily done by anding the value with true.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#35: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2098:
+^Inew_link.link_status = (vf->link_up & true) ? $

ERROR:CODE_INDENT: code indent should use tabs where possible
#36: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2099:
+                            ETH_LINK_UP : ETH_LINK_DOWN;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#36: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2099:
+                            ETH_LINK_UP : ETH_LINK_DOWN;$

total: 2 errors, 2 warnings, 0 checks, 10 lines checked

More information about the test-report mailing list