[dpdk-test-report] |WARNING| pw35232 [PATCH 34/80] net/sfc/base: add efsys macro to get memory region size

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 20 08:36:00 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35232

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#43: FILE: drivers/net/sfc/base/ef10_rx.c:40:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_RXQ_SIZE(ndescs))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#74: FILE: drivers/net/sfc/base/ef10_tx.c:45:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_TXQ_SIZE(ndescs))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#112: FILE: drivers/net/sfc/base/efx_intr.c:294:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_INTR_SIZE)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#127: FILE: drivers/net/sfc/base/efx_intr.c:333:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#140: FILE: drivers/net/sfc/base/efx_mcdi.c:1818:
+		uint32_t bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'esmp == NULL'
#158: FILE: drivers/net/sfc/base/siena_phy.c:537:
+	if ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_PHY_STATS_SIZE)) {

total: 1 errors, 1 warnings, 4 checks, 128 lines checked


More information about the test-report mailing list