[dpdk-test-report] |WARNING| pw35285 [PATCH 52/80] net/sfc/base: move PHY/link config to ef10 NIC board cfg

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 20 08:48:19 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35285

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#35: FILE: drivers/net/sfc/base/ef10_nic.c:1552:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#44: FILE: drivers/net/sfc/base/ef10_nic.c:1625:
+	if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#48: FILE: drivers/net/sfc/base/ef10_nic.c:1629:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

total: 2 errors, 0 warnings, 1 checks, 300 lines checked


More information about the test-report mailing list