[dpdk-test-report] |WARNING| pw42554 [v5, 15/23] net/softnic: add cli to enable and disable pipeline

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jul 6 19:23:24 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42554

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#130: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1791:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "enable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#137: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1798:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[4], "disable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:204:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:204:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:204:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:204:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#262: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:204:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL) ||
+		(p->n_ports_in == 0) ||
+		(p->n_ports_out == 0) ||
+		(p->n_tables == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->enabled == 0'
#270: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:212:
+	if ((t->enabled == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#353: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:295:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#353: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:295:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(p == NULL))

total: 0 errors, 0 warnings, 10 checks, 481 lines checked


More information about the test-report mailing list