[dpdk-test-report] |WARNING| pw40830 [PATCH 04/21] net/softnic: add mempool object

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 8 16:19:08 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40830

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#134: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'name == NULL'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+	if ((name == NULL) ||
+		mempool_find(p, name) ||
+		(params == NULL) ||
+		(params->buffer_size < BUFFER_SIZE_MIN) ||
+		(params->pool_size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params == NULL'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+	if ((name == NULL) ||
+		mempool_find(p, name) ||
+		(params == NULL) ||
+		(params->buffer_size < BUFFER_SIZE_MIN) ||
+		(params->pool_size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->buffer_size < BUFFER_SIZE_MIN'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+	if ((name == NULL) ||
+		mempool_find(p, name) ||
+		(params == NULL) ||
+		(params->buffer_size < BUFFER_SIZE_MIN) ||
+		(params->pool_size == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->pool_size == 0'
#198: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:65:
+	if ((name == NULL) ||
+		mempool_find(p, name) ||
+		(params == NULL) ||
+		(params->buffer_size < BUFFER_SIZE_MIN) ||
+		(params->pool_size == 0))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#210: FILE: drivers/net/softnic/rte_eth_softnic_mempool.c:77:
+	m = rte_pktmbuf_pool_create(

total: 0 errors, 1 warnings, 5 checks, 186 lines checked


More information about the test-report mailing list