[dpdk-test-report] |WARNING| pw40840 [PATCH 14/21] net/softnic: add cli to create softnic objects

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 8 16:19:25 CEST 2018
Previous message: [dpdk-test-report] |WARNING| pw40839 [PATCH 13/21] net/softnic: add connection agent
Next message: [dpdk-test-report] |WARNING| pw40841 [PATCH 15/21] net/softnic: add cli to enable and disable pipeline
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40840

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#119: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:124:
+	if (strcmp(tokens[2], "dev") == 0)
[...]
+	else if (strcmp(tokens[2], "port") == 0) {
[...]
+	} else {
[...]

WARNING:LONG_LINE_COMMENT: line over 90 characters
#208: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:213:
+ *  [filter match | mismatch offset <key_offset> mask <key_mask> key <key_value> port <port_id>]

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#249: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:254:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "filter") == 0)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#257: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:262:
+		if (strcmp(tokens[t0 + 1], "match") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "mismatch") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#261: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:266:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'size != RTE_PORT_IN_ACTION_FLTR_KEY_SIZE'
#282: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:287:
+		if ((parse_hex_string(tokens[t0 + 5], p.fltr.key_mask, &size) != 0) ||
+			(size != RTE_PORT_IN_ACTION_FLTR_KEY_SIZE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'size != RTE_PORT_IN_ACTION_FLTR_KEY_SIZE'
#294: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:299:
+		if ((parse_hex_string(tokens[t0 + 7], p.fltr.key, &size) != 0) ||
+			(size != RTE_PORT_IN_ACTION_FLTR_KEY_SIZE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#314: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:319:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "balance") == 0)) {

WARNING:LONG_LINE: line over 90 characters
#339: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:344:
+		if (parse_hex_string(tokens[t0 + 4], p.lb.key_mask, &p.lb.key_size) != 0) {

WARNING:LONG_LINE: line over 90 characters
#350: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:355:
+			if (parser_read_uint32(&p.lb.port_id[i], tokens[t0 + 6 + i]) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#420: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:425:
+	if (strcmp(tokens[4], "ipv4") == 0)
[...]
+	else if (strcmp(tokens[4], "ipv6") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#424: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:429:
+	else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#447: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:452:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "balance") == 0)) {

WARNING:LONG_LINE: line over 90 characters
#469: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:474:
+		if (parse_hex_string(tokens[t0 + 4], p.lb.key_mask, &p.lb.key_size) != 0) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#488: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:493:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "meter") == 0)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#495: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:500:
+		if (strcmp(tokens[t0 + 1], "srtcm") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "trtcm") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#499: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:504:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#542: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:547:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "tm") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#577: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:582:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "encap") == 0)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#584: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:589:
+		if (strcmp(tokens[t0 + 1], "ether") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "vlan") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "qinq") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "mpls") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "pppoe") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#594: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:599:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#603: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:608:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "nat") == 0)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#610: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:615:
+		if (strcmp(tokens[t0 + 1], "src") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "dst") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#614: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:619:
+		else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#625: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:630:
+		if (strcmp(tokens[t0 + 3], "tcp") == 0)
[...]
+		else if (strcmp(tokens[t0 + 3], "udp") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#629: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:634:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#639: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:644:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "ttl") == 0)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#646: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:651:
+		if (strcmp(tokens[t0 + 1], "drop") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "fwd") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#650: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:655:
+		else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#661: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:666:
+		if (strcmp(tokens[t0 + 3], "none") == 0)
[...]
+		else if (strcmp(tokens[t0 + 3], "pkts") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#665: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:670:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#675: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:680:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "stats") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't0 < n_tokens'
#701: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:706:
+	if ((t0 < n_tokens) && (strcmp(tokens[t0], "time") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens > t0'
#943: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:948:
+	if ((n_tokens > t0) && (strcmp(tokens[t0], "action") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens > t0'
#955: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:960:
+	if ((n_tokens > t0) &&
+		(strcmp(tokens[t0], "disabled") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7'
#1077: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1082:
+		if ((n_tokens != 7) && (n_tokens != 11)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 11'
#1077: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1082:
+		if ((n_tokens != 7) && (n_tokens != 11)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1185: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1190:
+		if (strcmp(tokens[t0 + 1], "ipv4") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "ipv6") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1189: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1194:
+		else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1262: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1267:
+		if (strcmp(tokens[t0 + 1], "ext") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "lru") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1266: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1271:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p.match.hash.key_size == 0'
#1277: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1282:
+		if ((parser_read_uint32(&p.match.hash.key_size,
+			tokens[t0 + 3]) != 0) ||
+			(p.match.hash.key_size == 0) ||
+			(p.match.hash.key_size > TABLE_RULE_MATCH_SIZE_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p.match.hash.key_size > TABLE_RULE_MATCH_SIZE_MAX'
#1277: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1282:
+		if ((parser_read_uint32(&p.match.hash.key_size,
+			tokens[t0 + 3]) != 0) ||
+			(p.match.hash.key_size == 0) ||
+			(p.match.hash.key_size > TABLE_RULE_MATCH_SIZE_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'key_mask_size != p.match.hash.key_size'
#1290: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1295:
+		if ((parse_hex_string(tokens[t0 + 5],
+			key_mask, &key_mask_size) != 0) ||
+			(key_mask_size != p.match.hash.key_size)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1341: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1346:
+		if (strcmp(tokens[t0 + 1], "ipv4") == 0)
[...]
+		else if (strcmp(tokens[t0 + 1], "ipv6") == 0)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1345: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1350:
+		else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens > t0'
#1384: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1389:
+	if ((n_tokens > t0) && (strcmp(tokens[t0], "action") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 3'
#1607: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1615:
+		if ((n_tokens >= 3) &&
+			(strcmp(tokens[2], "period") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#1613: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1621:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "in") == 0) &&
+			(strcmp(tokens[4], "bsz") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#1621: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1629:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "out") == 0) &&
+			(strcmp(tokens[4], "bsz") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 4'
#1629: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1637:
+		if ((n_tokens >= 4) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[3], "match") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#1636: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1644:
+		if ((n_tokens >= 6) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "in") == 0) &&
+			(strcmp(tokens[5], "table") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#1645: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1653:
+		if ((n_tokens >= 6) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "in") == 0) &&
+			(strcmp(tokens[5], "enable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#1654: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1662:
+		if ((n_tokens >= 6) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "in") == 0) &&
+			(strcmp(tokens[5], "disable") == 0)) {

CHECK:SPACING: No space is necessary after a cast
#1821: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:209:
+		status = rte_ring_sc_dequeue(msgq_rsp, (void **) &rsp);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#1842: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:230:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#1842: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:230:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_in'
#1842: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:230:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#1885: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:273:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#1885: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:273:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_in'
#1885: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:273:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:SPACING: No space is necessary after a cast
#1925: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:332:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#1938: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:345:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 4 warnings, 59 checks, 1919 lines checked
Previous message: [dpdk-test-report] |WARNING| pw40839 [PATCH 13/21] net/softnic: add connection agent
Next message: [dpdk-test-report] |WARNING| pw40841 [PATCH 15/21] net/softnic: add cli to enable and disable pipeline
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list