[dpdk-test-report] |WARNING| pw41216 [v2] [PATCH 22/22] app/testpmd: rework softnic forward mode

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 15 18:58:12 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41216

_coding style issues_


WARNING:TYPO_SPELLING: 'firware' may be misspelled - perhaps 'firmware'?
#22: 
$ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=script.cli'

ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#163: FILE: app/test-pmd/config.c:2348:
+				softnic_enable =1;
 				               ^

ERROR:SPACING: space required before the open parenthesis '('
#206: FILE: app/test-pmd/config.c:2392:
+	if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {

ERROR:SPACING: space required before the open parenthesis '('
#435: FILE: app/test-pmd/softnicfwd.c:150:
+	for(;;) {

WARNING:RETURN_VOID: void function return statements are not generally useful
#443: FILE: app/test-pmd/softnicfwd.c:158:
+	return;
+}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#447: FILE: app/test-pmd/softnicfwd.c:162:
+static int
+softnic_begin(void *arg __rte_unused) {

ERROR:SPACING: space required before the open parenthesis '('
#454: FILE: app/test-pmd/softnicfwd.c:169:
+	} while(!softnic_fwd_lcore->stopped);

WARNING:RETURN_VOID: void function return statements are not generally useful
#711: FILE: app/test-pmd/softnicfwd.c:683:
+	return;
+}

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#720: FILE: app/test-pmd/softnicfwd.c:690:
+};

total: 5 errors, 4 warnings, 768 lines checked


More information about the test-report mailing list