[dpdk-test-report] |WARNING| pw35824 [PATCH v3 05/18] net/axgbe: add phy initialization and related apis

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 9 09:44:28 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35824

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#1099: FILE: drivers/net/axgbe/axgbe_mdio.c:134:
+	if (pdata->phy.advertising & ADVERTISED_10000baseKR_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#1101: FILE: drivers/net/axgbe/axgbe_mdio.c:136:
+	else if (pdata->phy.advertising & ADVERTISED_10000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#1103: FILE: drivers/net/axgbe/axgbe_mdio.c:138:
+	else if (pdata->phy.advertising & ADVERTISED_2500baseX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#1105: FILE: drivers/net/axgbe/axgbe_mdio.c:140:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseKX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#1107: FILE: drivers/net/axgbe/axgbe_mdio.c:142:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#1109: FILE: drivers/net/axgbe/axgbe_mdio.c:144:
+	else if (pdata->phy.advertising & ADVERTISED_100baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#1135: FILE: drivers/net/axgbe/axgbe_mdio.c:170:
+	if (pdata->phy.advertising & ADVERTISED_Autoneg) {

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#1152: FILE: drivers/net/axgbe/axgbe_mdio.c:187:
+	pdata->phy.advertising &= ~ADVERTISED_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#1153: FILE: drivers/net/axgbe/axgbe_mdio.c:188:
+	pdata->phy.advertising &= ~ADVERTISED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Autoneg>
#1807: FILE: drivers/net/axgbe/axgbe_phy_impl.c:633:
+		pdata->phy.supported |= SUPPORTED_Autoneg;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Pause>
#1808: FILE: drivers/net/axgbe/axgbe_phy_impl.c:634:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Asym_Pause>
#1808: FILE: drivers/net/axgbe/axgbe_phy_impl.c:634:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Backplane>
#1809: FILE: drivers/net/axgbe/axgbe_phy_impl.c:635:
+		pdata->phy.supported |= SUPPORTED_Backplane;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseKX_Full>
#1811: FILE: drivers/net/axgbe/axgbe_phy_impl.c:637:
+			pdata->phy.supported |= SUPPORTED_1000baseKX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseKR_Full>
#1815: FILE: drivers/net/axgbe/axgbe_phy_impl.c:641:
+			pdata->phy.supported |= SUPPORTED_10000baseKR_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseR_FEC>
#1818: FILE: drivers/net/axgbe/axgbe_phy_impl.c:644:
+					SUPPORTED_10000baseR_FEC;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_2500baseX_Full>
#1827: FILE: drivers/net/axgbe/axgbe_phy_impl.c:653:
+		pdata->phy.supported |= SUPPORTED_2500baseX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_100baseT_Full>
#1839: FILE: drivers/net/axgbe/axgbe_phy_impl.c:665:
+			pdata->phy.supported |= SUPPORTED_100baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseT_Full>
#1843: FILE: drivers/net/axgbe/axgbe_phy_impl.c:669:
+			pdata->phy.supported |= SUPPORTED_1000baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseT_Full>
#1896: FILE: drivers/net/axgbe/axgbe_phy_impl.c:722:
+			pdata->phy.supported |= SUPPORTED_10000baseT_Full;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE'
#1946: FILE: drivers/net/axgbe/axgbe_phy_impl.c:772:
+	if ((phy_data->conn_type & AXGBE_CONN_TYPE_MDIO) &&
+	    (phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE)) {

total: 0 errors, 0 warnings, 21 checks, 1899 lines checked


More information about the test-report mailing list