[dpdk-test-report] |WARNING| pw36175 [PATCH] ethdev: return diagnostic when setting MAC address
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Mar 16 16:43:35 CET 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36175
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#79:
> drivers/net/tap/rte_eth_tap.c | 34 +++++++++++++++++++++------------
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#145:
@@ -982,14 +995,13 @@
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#198: FILE: drivers/net/sfc/sfc_ethdev.c:941:
+Â Â Â Â Â Â /*
+Â Â Â Â Â Â Â * Neither of the two following checks can return
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#203: FILE: drivers/net/sfc/sfc_ethdev.c:946:
+Â Â Â Â Â Â Â */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#204: FILE: drivers/net/sfc/sfc_ethdev.c:947:
       if (port->isolated) {
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â sfc_warn(sa, "isolated mode is active on the port");
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#217: FILE: drivers/net/sfc/sfc_ethdev.c:973:
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (rc != 0) {
                       sfc_err(sa, "cannot set filter (rc = %u)", rc);
ERROR:TRAILING_WHITESPACE: trailing whitespace
#221: FILE: drivers/net/sfc/sfc_ethdev.c:977:
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (void)efx_mac_addr_set(sa->nic, $
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#222: FILE: drivers/net/sfc/sfc_ethdev.c:977:
old_addr->addr_bytes);
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 5 warnings, 0 checks, 48 lines checked
More information about the test-report
mailing list