[dpdk-test-report] |WARNING| pw39317 [PATCH] Compiling DPDK with CentOS6

checkpatch at dpdk.org checkpatch at dpdk.org
Thu May 3 16:20:57 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39317

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
This is my first post on this list, apologize if I am posting in the wrong dpdk list, or if this is not relevant.

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#29: 
@@ -370,7 +370,7 @@ CONFIG_RTE_LIBRTE_PMD_AF_PACKET=n

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#61: 
commit f218129f0584f8d94f61071ff5b759605f6cf52e

WARNING:BAD_SIGN_OFF: Do not use whitespace before Signed-off-by:
#67: 
    Signed-off-by: shahar salzman <shahar.salzman at kaminario.com>

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#82: FILE: lib/librte_compat/rte_compat.h:81:
+#if (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6, 4))

WARNING:LONG_LINE: line over 90 characters
#88: FILE: lib/librte_compat/rte_compat.h:87:
+#define __rte_experimental  __attribute__((deprecated)) __attribute__((section(".text.experimental")))

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#88: FILE: lib/librte_compat/rte_compat.h:87:
+#define __rte_experimental  __attribute__((deprecated)) __attribute__((section(".text.experimental")))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#103: FILE: lib/librte_eal/common/include/rte_common.h:457:
+#define RHEL_RELEASE_VERSION(a,b) (((a) << 8) + (b))
                               ^

total: 4 errors, 4 warnings, 27 lines checked


More information about the test-report mailing list