[dpdk-test-report] |WARNING| pw39358 [PATCH 1/4] net/bnxt: update HWRM to version 1.9.2

checkpatch at dpdk.org checkpatch at dpdk.org
Thu May 3 19:42:30 CEST 2018
Previous message: [dpdk-test-report] |FAILURE| pw39356[dpdk-dev, 4/4] net/bnxt: add NVM specific HWRM commands
Next message: [dpdk-test-report] |SUCCESS| pw38594 [PATCH 1/9 v2] bus/fslmc: support MC DPDMAI object
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39358

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#174: FILE: drivers/net/bnxt/bnxt_ring.c:86:
+				   sizeof (struct hwrm_resp_hdr)) : 0;

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1012: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:438:
+	/* Engine CKV - Get the current allocation status of keys provisioned in the key vault. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#11070: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:5787:
+	/* This value indicates the type of OS.  The values are based on CIM_OperatingSystem.mof file as published by the DMTF. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#11826: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:6210:
+	/* This value indicates the type of OS.  The values are based on CIM_OperatingSystem.mof file as published by the DMTF. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#15856: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:9772:
+	 * This flag should be ignored if FEC autonegotiation is not supported on this port.

WARNING:TYPO_SPELLING: 'correspoding' may be misspelled - perhaps 'corresponding'?
#16455: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10371:
+	 * # If the correspoding CoS mapping is not enabled, then this

WARNING:TYPO_SPELLING: 'correspoding' may be misspelled - perhaps 'corresponding'?
#16504: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10420:
+	 * # If the correspoding CoS mapping is not enabled, then this

WARNING:TYPO_SPELLING: 'correspoding' may be misspelled - perhaps 'corresponding'?
#16518: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10434:
+	 * # If the correspoding CoS mapping is not enabled, then this

WARNING:LONG_LINE: line over 90 characters
#19934: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:13850:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID0_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#19981: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:13897:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID0_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20056: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:13972:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID1_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20103: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14019:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID1_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20178: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14094:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID2_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20225: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14141:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID2_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20300: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14216:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID3_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20347: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14263:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID3_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20422: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14338:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID4_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20469: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14385:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID4_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20544: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14460:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID5_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20591: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14507:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID5_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20666: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14582:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID6_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20713: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14629:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID6_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20788: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14704:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID7_MIN_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#20835: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:14751:
+	#define HWRM_QUEUE_COS2BW_QCFG_OUTPUT_QUEUE_ID7_MAX_BW_BW_VALUE_UNIT_PERCENT1_100 \

WARNING:LONG_LINE: line over 90 characters
#25090: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:18425:
+	#define HWRM_RING_CMPL_RING_CFG_AGGINT_PARAMS_INPUT_ENABLES_NUM_CMPL_DMA_AGGR_DURING_INT \

WARNING:LONG_LINE_COMMENT: line over 90 characters
#29652: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20725:
+	/* Enhance Generic Routing Encapsulation (GRE version 1) inside IP datagram payload */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#29782: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20817:
+	/* Enhance Generic Routing Encapsulation (GRE version 1) inside IP datagram payload */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#29923: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20908:
+	/* Enhance Generic Routing Encapsulation (GRE version 1) inside IP datagram payload */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#31345: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:21730:
+	/* Number of times, the ROCE cos queue PFC is disabled to avoid pause flood/burst */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32593: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22373:
+	/* The Directory Entry Type (valid values are defined in the bnxnvm_directory_type enum defined in the file bnxnvm_defs.h). */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32603: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22380:
+	/* The Directory Entry Extension flags (see BNX_DIR_EXT_* in the file bnxnvm_defs.h). */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32605: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22382:
+	/* Directory Entry Attribute flags (see BNX_DIR_ATTR_* in the file bnxnvm_defs.h). */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32610: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22385:
+	 * Length of data to write, in bytes. May be less than or equal to the allocated size for the directory entry.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32611: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22386:
+	 * The data length stored in the directory entry will be updated to reflect this value once the write is complete.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32634: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22399:
+	 * The requested length of the allocated NVM for the item, in bytes. This value may be greater than or equal to the specified data length (dir_data_length).

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32636: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22401:
+	 * The response will contain the actual allocated item length, which may be greater than the requested item length.

WARNING:TYPO_SPELLING: 'accomodate' may be misspelled - perhaps 'accommodate'?
#32637: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22402:
+	 * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accomodate

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32637: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22402:
+	 * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accomodate

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32638: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22403:
+	 * the potential future growth of an item (e.g. upgraded firmware with a size increase, log growth, expanded configuration data).

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32685: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22420:
+	 * Length of the allocated NVM for the item, in bytes. The value may be greater than or equal to the specified data length or the requested item length.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32686: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22421:
+	 * The actual item length used when creating a new directory entry will be a multiple of an NVM block size.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#32978: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:22612:
+	 * Only valid if the directory entry is for embedded firmware stored in APE_BIN Format.

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 42 warnings, 0 checks, 33057 lines checked
Previous message: [dpdk-test-report] |FAILURE| pw39356[dpdk-dev, 4/4] net/bnxt: add NVM specific HWRM commands
Next message: [dpdk-test-report] |SUCCESS| pw38594 [PATCH 1/9 v2] bus/fslmc: support MC DPDMAI object
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list