[dpdk-test-report] |WARNING| pw39427 [PATCH v2 2/2] net/mlx5: free eth dev port in case of error

checkpatch at dpdk.org checkpatch at dpdk.org
Mon May 7 19:57:14 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39427

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#38: 
> @@ -1063,6 +1063,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#65: FILE: lib/librte_ethdev/rte_ethdev.c:352:
	eth_dev->state = RTE_ETH_DEV_UNUSED;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#68: FILE: lib/librte_ethdev/rte_ethdev.c:354:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));

ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: lib/librte_ethdev/rte_ethdev.c:355:
+               memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 4 warnings, 9 lines checked


More information about the test-report mailing list