[dpdk-test-report] |WARNING| pw46179 [2/3] net/sfc: support TSO in EF10 Tx datapath
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Oct 5 16:48:53 CEST 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/46179
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len > SFC_TSOH_STD_LEN'
#199: FILE: drivers/net/sfc/sfc_ef10_tx.c:344:
+ if (unlikely((header_len > SFC_TSOH_STD_LEN) |
+ (tcph_off > txq->tso_tcp_header_offset_limit)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcph_off > txq->tso_tcp_header_offset_limit'
#199: FILE: drivers/net/sfc/sfc_ef10_tx.c:344:
+ if (unlikely((header_len > SFC_TSOH_STD_LEN) |
+ (tcph_off > txq->tso_tcp_header_offset_limit)))
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EMSGSIZE)
#201: FILE: drivers/net/sfc/sfc_ef10_tx.c:346:
+ return EMSGSIZE;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#222: FILE: drivers/net/sfc/sfc_ef10_tx.c:367:
+ return ENOSPC;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EMSGSIZE)
#231: FILE: drivers/net/sfc/sfc_ef10_tx.c:376:
+ return EMSGSIZE;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#292: FILE: drivers/net/sfc/sfc_ef10_tx.c:437:
+ return EINVAL;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#360: FILE: drivers/net/sfc/sfc_ef10_tx.c:505:
+ return ENOSPC;
total: 0 errors, 5 warnings, 2 checks, 437 lines checked
More information about the test-report
mailing list