[dpdk-test-report] |WARNING| pw44155 [6/7] net/bnxt: add support to enable new mailbox channel

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Sep 1 06:35:01 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44155

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'req' - possible side-effects?
#122: FILE: drivers/net/bnxt/bnxt_hwrm.c:163:
+#define HWRM_PREP(req, type, kong) do { \
 	rte_spinlock_lock(&bp->hwrm_lock); \
 	memset(bp->hwrm_cmd_resp_addr, 0, bp->max_resp_len); \
 	req.req_type = rte_cpu_to_le_16(HWRM_##type); \
 	req.cmpl_ring = rte_cpu_to_le_16(-1); \
+	req.seq_id = kong ? rte_cpu_to_le_16(bp->kong_cmd_seq++) :\
+		rte_cpu_to_le_16(bp->hwrm_cmd_seq++); \
 	req.target_id = rte_cpu_to_le_16(0xffff); \
 	req.resp_addr = rte_cpu_to_le_64(bp->hwrm_cmd_resp_dma_addr); \
 } while (0)

total: 0 errors, 0 warnings, 1 checks, 1171 lines checked


More information about the test-report mailing list