[dpdk-test-report] |WARNING| pw44401 [07/21] net/atlantic: hardware register access routines

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:24:53 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44401

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#73: FILE: drivers/net/atlantic/atl_hw_regs.c:42:
+	return rte_le_to_cpu_32(rte_read32((u8*)hw->mmio + reg));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#78: FILE: drivers/net/atlantic/atl_hw_regs.c:47:
+	rte_write32((rte_cpu_to_le_32(value)), (u8*)hw->mmio + reg);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects?
#130: FILE: drivers/net/atlantic/atl_hw_regs.h:35:
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#131: FILE: drivers/net/atlantic/atl_hw_regs.h:36:
+#define BIT(x)	(1UL << x)

total: 2 errors, 0 warnings, 2 checks, 117 lines checked


More information about the test-report mailing list