[dpdk-test-report] |WARNING| pw44677 [v2, 21/21] net/atlantic: TX side structures and implementation

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 13 13:41:16 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44677

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->nb_segs == 0'
#710: FILE: drivers/net/atlantic/atl_rxtx.c:1353:
+		if ((tx_pkt->nb_segs == 0) ||
+			((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->nb_segs > 1'
#710: FILE: drivers/net/atlantic/atl_rxtx.c:1353:
+		if ((tx_pkt->nb_segs == 0) ||
+			((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->next == NULL'
#710: FILE: drivers/net/atlantic/atl_rxtx.c:1353:
+		if ((tx_pkt->nb_segs == 0) ||
+			((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL)))

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'atl_xmit_pkts', this function's name, in a string
#718: FILE: drivers/net/atlantic/atl_rxtx.c:1361:
+	PMD_TX_LOG(DEBUG, "atl_xmit_pkts %d transmitted", nb_tx);

total: 0 errors, 1 warnings, 3 checks, 675 lines checked


More information about the test-report mailing list