[dpdk-test-report] |WARNING| pw52573 [PATCH 07/10] net/atlantic: interrupt handling of macsec events

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Apr 10 13:19:43 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52573

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#48: FILE: drivers/net/atlantic/atl_ethdev.c:7:
+#include <rte_alarm.h>^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: drivers/net/atlantic/atl_ethdev.c:1093:
+static void^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#57: FILE: drivers/net/atlantic/atl_ethdev.c:1094:
+atl_dev_delayed_handler(void *param)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#58: FILE: drivers/net/atlantic/atl_ethdev.c:1095:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#59: FILE: drivers/net/atlantic/atl_ethdev.c:1096:
+^Istruct rte_eth_dev *dev = (struct rte_eth_dev *)param;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#60: FILE: drivers/net/atlantic/atl_ethdev.c:1097:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#61: FILE: drivers/net/atlantic/atl_ethdev.c:1098:
+^Iatl_dev_configure_macsec(dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#62: FILE: drivers/net/atlantic/atl_ethdev.c:1099:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#63: FILE: drivers/net/atlantic/atl_ethdev.c:1100:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#64: FILE: drivers/net/atlantic/atl_ethdev.c:1101:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#88: FILE: drivers/net/atlantic/atl_ethdev.c:1142:
+^Iif (rte_eal_alarm_set(1000 * 1000,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#89: FILE: drivers/net/atlantic/atl_ethdev.c:1143:
+^I^I^I      atl_dev_delayed_handler, (void *)dev) < 0)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#90: FILE: drivers/net/atlantic/atl_ethdev.c:1144:
+^I^IPMD_DRV_LOG(ERR, "rte_eal_alarm_set fail");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#91: FILE: drivers/net/atlantic/atl_ethdev.c:1145:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#101: FILE: drivers/net/atlantic/atl_ethdev.c:1223:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#102: FILE: drivers/net/atlantic/atl_ethdev.c:1224:
+^Iif (cause & BIT(ATL_IRQ_CAUSE_LINK))^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#103: FILE: drivers/net/atlantic/atl_ethdev.c:1225:
+^I^Iintr->flags |= ATL_FLAG_NEED_LINK_UPDATE;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#111: FILE: drivers/net/atlantic/atl_ethdev.c:1290:
+^Istruct atl_adapter *adapter =^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#112: FILE: drivers/net/atlantic/atl_ethdev.c:1291:
+^I^I(struct atl_adapter *)dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#113: FILE: drivers/net/atlantic/atl_ethdev.c:1292:
+^Istruct aq_hw_s *hw = &adapter->hw;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#114: FILE: drivers/net/atlantic/atl_ethdev.c:1293:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: drivers/net/atlantic/atl_ethdev.c:1294:
+^Iif (!(intr->flags & ATL_FLAG_NEED_LINK_UPDATE))^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#116: FILE: drivers/net/atlantic/atl_ethdev.c:1295:
+^I^Igoto done;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#121: FILE: drivers/net/atlantic/atl_ethdev.c:1297:
+^Iintr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#122: FILE: drivers/net/atlantic/atl_ethdev.c:1298:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#123: FILE: drivers/net/atlantic/atl_ethdev.c:1299:
+^I/* Notify userapp if link status changed */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#124: FILE: drivers/net/atlantic/atl_ethdev.c:1300:
+^Iif (!atl_dev_link_update(dev, 0)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#128: FILE: drivers/net/atlantic/atl_ethdev.c:1304:
+^I} else {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#129: FILE: drivers/net/atlantic/atl_ethdev.c:1305:
+^I^Iif (hw->aq_fw_ops->send_macsec_req == NULL)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#130: FILE: drivers/net/atlantic/atl_ethdev.c:1306:
+^I^I^Igoto done;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#131: FILE: drivers/net/atlantic/atl_ethdev.c:1307:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#132: FILE: drivers/net/atlantic/atl_ethdev.c:1308:
+^I^I/* Check macsec Keys expired */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#133: FILE: drivers/net/atlantic/atl_ethdev.c:1309:
+^I^Istruct get_stats req = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#134: FILE: drivers/net/atlantic/atl_ethdev.c:1310:
+^I^Istruct macsec_msg_fw_request msg = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#135: FILE: drivers/net/atlantic/atl_ethdev.c:1311:
+^I^Istruct macsec_msg_fw_response resp = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#136: FILE: drivers/net/atlantic/atl_ethdev.c:1312:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#137: FILE: drivers/net/atlantic/atl_ethdev.c:1313:
+^I^Ireq.ingress_sa_index = 0x0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#138: FILE: drivers/net/atlantic/atl_ethdev.c:1314:
+^I^Ireq.egress_sc_index = 0x0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#139: FILE: drivers/net/atlantic/atl_ethdev.c:1315:
+^I^Ireq.egress_sa_index = 0x0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#140: FILE: drivers/net/atlantic/atl_ethdev.c:1316:
+^I^Imsg.msg_type = macsec_get_stats_msg;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#141: FILE: drivers/net/atlantic/atl_ethdev.c:1317:
+^I^Imsg.stats = req;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: drivers/net/atlantic/atl_ethdev.c:1318:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: drivers/net/atlantic/atl_ethdev.c:1319:
+^I^Iint err = hw->aq_fw_ops->send_macsec_req(hw, &msg, &resp);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: drivers/net/atlantic/atl_ethdev.c:1320:
+^I^Iif (err) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: drivers/net/atlantic/atl_ethdev.c:1321:
+^I^I^IPMD_DRV_LOG(ERR, "send_macsec_req fail");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: drivers/net/atlantic/atl_ethdev.c:1322:
+^I^I^Igoto done;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#147: FILE: drivers/net/atlantic/atl_ethdev.c:1323:
+^I^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#148: FILE: drivers/net/atlantic/atl_ethdev.c:1324:
+^I^Iif (resp.stats.egress_threshold_expired ||^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#149: FILE: drivers/net/atlantic/atl_ethdev.c:1325:
+^I^I    resp.stats.ingress_threshold_expired ||^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#150: FILE: drivers/net/atlantic/atl_ethdev.c:1326:
+^I^I    resp.stats.egress_expired ||^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#151: FILE: drivers/net/atlantic/atl_ethdev.c:1327:
+^I^I    resp.stats.ingress_expired) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#152: FILE: drivers/net/atlantic/atl_ethdev.c:1328:
+^I^I^IPMD_DRV_LOG(INFO, "RTE_ETH_EVENT_MACSEC");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#153: FILE: drivers/net/atlantic/atl_ethdev.c:1329:
+^I^I^I_rte_eth_dev_callback_process(dev,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#154: FILE: drivers/net/atlantic/atl_ethdev.c:1330:
+^I^I^I^IRTE_ETH_EVENT_MACSEC, NULL);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#155: FILE: drivers/net/atlantic/atl_ethdev.c:1331:
+^I^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#158: FILE: drivers/net/atlantic/atl_ethdev.c:1333:
+done:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#171: FILE: drivers/net/atlantic/atl_ethdev.h:37:
+#define ATL_FLAG_MACSEC (uint32_t)(4 << 0)^M$

total: 57 errors, 0 warnings, 0 checks, 120 lines checked


More information about the test-report mailing list