[dpdk-test-report] |WARNING| pw52710 [PATCH v4 12/13] net/enetc: enable Rx checksum offload validation

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 12 14:30:08 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52710

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#36: FILE: doc/guides/nics/features/enetc.ini:16:
+L3 checksum offload  = P^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#37: FILE: doc/guides/nics/features/enetc.ini:17:
+L4 checksum offload  = P^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#49: FILE: drivers/net/enetc/base/enetc_hw.h:102:
+#define ENETC_PAR_PORT_CFG^I^I0x03050^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#50: FILE: drivers/net/enetc/base/enetc_hw.h:103:
+#define L3_CKSUM^I^I^IBIT(0)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#51: FILE: drivers/net/enetc/base/enetc_hw.h:104:
+#define L4_CKSUM^I^I^IBIT(1)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#52: FILE: drivers/net/enetc/base/enetc_hw.h:105:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#60: FILE: drivers/net/enetc/base/enetc_hw.h:189:
+#define ENETC_PARSE_ERROR^I^I0x8000^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: drivers/net/enetc/enetc_ethdev.c:166:
+^I^I(DEV_RX_OFFLOAD_IPV4_CKSUM |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#74: FILE: drivers/net/enetc/enetc_ethdev.c:167:
+^I^I DEV_RX_OFFLOAD_UDP_CKSUM |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#75: FILE: drivers/net/enetc/enetc_ethdev.c:168:
+^I^I DEV_RX_OFFLOAD_TCP_CKSUM |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#76: FILE: drivers/net/enetc/enetc_ethdev.c:169:
+^I^I DEV_RX_OFFLOAD_KEEP_CRC |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#84: FILE: drivers/net/enetc/enetc_ethdev.c:642:
+^Iuint32_t checksum = L3_CKSUM | L4_CKSUM;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#92: FILE: drivers/net/enetc/enetc_ethdev.c:668:
+^Iif (rx_offloads & DEV_RX_OFFLOAD_IPV4_CKSUM)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#93: FILE: drivers/net/enetc/enetc_ethdev.c:669:
+^I^Ichecksum &= ~L3_CKSUM;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#94: FILE: drivers/net/enetc/enetc_ethdev.c:670:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#95: FILE: drivers/net/enetc/enetc_ethdev.c:671:
+^Iif (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM))^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#96: FILE: drivers/net/enetc/enetc_ethdev.c:672:
+^I^Ichecksum &= ~L4_CKSUM;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#97: FILE: drivers/net/enetc/enetc_ethdev.c:673:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#98: FILE: drivers/net/enetc/enetc_ethdev.c:674:
+^Ienetc_port_wr(enetc_hw, ENETC_PAR_PORT_CFG, checksum);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#99: FILE: drivers/net/enetc/enetc_ethdev.c:675:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#100: FILE: drivers/net/enetc/enetc_ethdev.c:676:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#112: FILE: drivers/net/enetc/enetc_rxtx.c:118:
+static inline void enetc_slow_parsing(struct rte_mbuf *m,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#113: FILE: drivers/net/enetc/enetc_rxtx.c:119:
+^I^I^I^I     uint64_t parse_results)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#114: FILE: drivers/net/enetc/enetc_rxtx.c:120:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: drivers/net/enetc/enetc_rxtx.c:121:
+^Im->ol_flags &= ~(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#116: FILE: drivers/net/enetc/enetc_rxtx.c:122:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#117: FILE: drivers/net/enetc/enetc_rxtx.c:123:
+^Iswitch (parse_results) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#118: FILE: drivers/net/enetc/enetc_rxtx.c:124:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV4:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#119: FILE: drivers/net/enetc/enetc_rxtx.c:125:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#120: FILE: drivers/net/enetc/enetc_rxtx.c:126:
+^I^I^I^I RTE_PTYPE_L3_IPV4;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#121: FILE: drivers/net/enetc/enetc_rxtx.c:127:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#122: FILE: drivers/net/enetc/enetc_rxtx.c:128:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#123: FILE: drivers/net/enetc/enetc_rxtx.c:129:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV6:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#124: FILE: drivers/net/enetc/enetc_rxtx.c:130:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#125: FILE: drivers/net/enetc/enetc_rxtx.c:131:
+^I^I^I^I RTE_PTYPE_L3_IPV6;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#126: FILE: drivers/net/enetc/enetc_rxtx.c:132:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#127: FILE: drivers/net/enetc/enetc_rxtx.c:133:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#128: FILE: drivers/net/enetc/enetc_rxtx.c:134:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV4_TCP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#129: FILE: drivers/net/enetc/enetc_rxtx.c:135:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#130: FILE: drivers/net/enetc/enetc_rxtx.c:136:
+^I^I^I^I RTE_PTYPE_L3_IPV4 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#131: FILE: drivers/net/enetc/enetc_rxtx.c:137:
+^I^I^I^I RTE_PTYPE_L4_TCP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#132: FILE: drivers/net/enetc/enetc_rxtx.c:138:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#133: FILE: drivers/net/enetc/enetc_rxtx.c:139:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#134: FILE: drivers/net/enetc/enetc_rxtx.c:140:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#135: FILE: drivers/net/enetc/enetc_rxtx.c:141:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV6_TCP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#136: FILE: drivers/net/enetc/enetc_rxtx.c:142:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#137: FILE: drivers/net/enetc/enetc_rxtx.c:143:
+^I^I^I^I RTE_PTYPE_L3_IPV6 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#138: FILE: drivers/net/enetc/enetc_rxtx.c:144:
+^I^I^I^I RTE_PTYPE_L4_TCP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#139: FILE: drivers/net/enetc/enetc_rxtx.c:145:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#140: FILE: drivers/net/enetc/enetc_rxtx.c:146:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#141: FILE: drivers/net/enetc/enetc_rxtx.c:147:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: drivers/net/enetc/enetc_rxtx.c:148:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV4_UDP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: drivers/net/enetc/enetc_rxtx.c:149:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: drivers/net/enetc/enetc_rxtx.c:150:
+^I^I^I^I RTE_PTYPE_L3_IPV4 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: drivers/net/enetc/enetc_rxtx.c:151:
+^I^I^I^I RTE_PTYPE_L4_UDP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: drivers/net/enetc/enetc_rxtx.c:152:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#147: FILE: drivers/net/enetc/enetc_rxtx.c:153:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#148: FILE: drivers/net/enetc/enetc_rxtx.c:154:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#149: FILE: drivers/net/enetc/enetc_rxtx.c:155:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV6_UDP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#150: FILE: drivers/net/enetc/enetc_rxtx.c:156:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#151: FILE: drivers/net/enetc/enetc_rxtx.c:157:
+^I^I^I^I RTE_PTYPE_L3_IPV6 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#152: FILE: drivers/net/enetc/enetc_rxtx.c:158:
+^I^I^I^I RTE_PTYPE_L4_UDP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#153: FILE: drivers/net/enetc/enetc_rxtx.c:159:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#154: FILE: drivers/net/enetc/enetc_rxtx.c:160:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#155: FILE: drivers/net/enetc/enetc_rxtx.c:161:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#156: FILE: drivers/net/enetc/enetc_rxtx.c:162:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV4_SCTP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#157: FILE: drivers/net/enetc/enetc_rxtx.c:163:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#158: FILE: drivers/net/enetc/enetc_rxtx.c:164:
+^I^I^I^I RTE_PTYPE_L3_IPV4 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#159: FILE: drivers/net/enetc/enetc_rxtx.c:165:
+^I^I^I^I RTE_PTYPE_L4_SCTP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#160: FILE: drivers/net/enetc/enetc_rxtx.c:166:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#161: FILE: drivers/net/enetc/enetc_rxtx.c:167:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#162: FILE: drivers/net/enetc/enetc_rxtx.c:168:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#163: FILE: drivers/net/enetc/enetc_rxtx.c:169:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV6_SCTP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#164: FILE: drivers/net/enetc/enetc_rxtx.c:170:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#165: FILE: drivers/net/enetc/enetc_rxtx.c:171:
+^I^I^I^I RTE_PTYPE_L3_IPV6 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#166: FILE: drivers/net/enetc/enetc_rxtx.c:172:
+^I^I^I^I RTE_PTYPE_L4_SCTP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#167: FILE: drivers/net/enetc/enetc_rxtx.c:173:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#168: FILE: drivers/net/enetc/enetc_rxtx.c:174:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#169: FILE: drivers/net/enetc/enetc_rxtx.c:175:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#170: FILE: drivers/net/enetc/enetc_rxtx.c:176:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV4_ICMP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#171: FILE: drivers/net/enetc/enetc_rxtx.c:177:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#172: FILE: drivers/net/enetc/enetc_rxtx.c:178:
+^I^I^I^I RTE_PTYPE_L3_IPV4 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#173: FILE: drivers/net/enetc/enetc_rxtx.c:179:
+^I^I^I^I RTE_PTYPE_L4_ICMP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#174: FILE: drivers/net/enetc/enetc_rxtx.c:180:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#175: FILE: drivers/net/enetc/enetc_rxtx.c:181:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#176: FILE: drivers/net/enetc/enetc_rxtx.c:182:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#177: FILE: drivers/net/enetc/enetc_rxtx.c:183:
+^Icase ENETC_PARSE_ERROR | ENETC_PKT_TYPE_IPV6_ICMP:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#178: FILE: drivers/net/enetc/enetc_rxtx.c:184:
+^I^Im->packet_type = RTE_PTYPE_L2_ETHER |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#179: FILE: drivers/net/enetc/enetc_rxtx.c:185:
+^I^I^I^I RTE_PTYPE_L3_IPV6 |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#180: FILE: drivers/net/enetc/enetc_rxtx.c:186:
+^I^I^I^I RTE_PTYPE_L4_ICMP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#181: FILE: drivers/net/enetc/enetc_rxtx.c:187:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#182: FILE: drivers/net/enetc/enetc_rxtx.c:188:
+^I^I^I       PKT_RX_L4_CKSUM_BAD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#183: FILE: drivers/net/enetc/enetc_rxtx.c:189:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#184: FILE: drivers/net/enetc/enetc_rxtx.c:190:
+^I/* More switch cases can be added */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#185: FILE: drivers/net/enetc/enetc_rxtx.c:191:
+^Idefault:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#186: FILE: drivers/net/enetc/enetc_rxtx.c:192:
+^I^Im->packet_type = RTE_PTYPE_UNKNOWN;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#187: FILE: drivers/net/enetc/enetc_rxtx.c:193:
+^I^Im->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN |^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#188: FILE: drivers/net/enetc/enetc_rxtx.c:194:
+^I^I^I       PKT_RX_L4_CKSUM_UNKNOWN;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#189: FILE: drivers/net/enetc/enetc_rxtx.c:195:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#190: FILE: drivers/net/enetc/enetc_rxtx.c:196:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#191: FILE: drivers/net/enetc/enetc_rxtx.c:197:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#197: FILE: drivers/net/enetc/enetc_rxtx.c:203:
+^Im->ol_flags |= PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#204: FILE: drivers/net/enetc/enetc_rxtx.c:208:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#209: FILE: drivers/net/enetc/enetc_rxtx.c:212:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#214: FILE: drivers/net/enetc/enetc_rxtx.c:216:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#220: FILE: drivers/net/enetc/enetc_rxtx.c:221:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#226: FILE: drivers/net/enetc/enetc_rxtx.c:226:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#232: FILE: drivers/net/enetc/enetc_rxtx.c:231:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#238: FILE: drivers/net/enetc/enetc_rxtx.c:236:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#244: FILE: drivers/net/enetc/enetc_rxtx.c:241:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#250: FILE: drivers/net/enetc/enetc_rxtx.c:246:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#256: FILE: drivers/net/enetc/enetc_rxtx.c:251:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#262: FILE: drivers/net/enetc/enetc_rxtx.c:256:
+^I^Ireturn;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#266: FILE: drivers/net/enetc/enetc_rxtx.c:259:
+^I^Ienetc_slow_parsing(m, parse_results);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#268: FILE: drivers/net/enetc/enetc_rxtx.c:261:
+^M$

total: 115 errors, 0 warnings, 0 checks, 221 lines checked


More information about the test-report mailing list