[dpdk-test-report] |WARNING| pw49578 [v2] net/softnic: add support for service cores

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jan 10 12:37:17 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49578

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->enabled'
#151: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+		if ((pipeline->enabled) && (pipeline->thread_id == thread_id))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->thread_id == thread_id'
#151: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+		if ((pipeline->enabled) && (pipeline->thread_id == thread_id))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#200: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(thread_id == cfg->master_lcore))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id == cfg->master_lcore'
#200: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+	if ((thread_id >= RTE_MAX_LCORE) ||
+		(thread_id == cfg->master_lcore))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_SERVICE'
#206: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+	if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+		(!softnic->params.sc && (role == ROLE_RTE)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_RTE'
#206: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+	if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+		(!softnic->params.sc && (role == ROLE_RTE)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+	if (!thread_is_valid(softnic, thread_id) ||
 		(p == NULL) ||
 		(p->n_ports_in == 0) ||
 		(p->n_ports_out == 0) ||
+		(p->n_tables == 0) ||
+		p->enabled)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#324: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:313:
+	if (softnic->params.sc && (n_pipelines == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#357: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+	if (!thread_is_valid(softnic, thread_id) ||
+		(p == NULL) ||
+		(p->enabled && (p->thread_id != thread_id)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->thread_id != thread_id'
#357: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+	if (!thread_is_valid(softnic, thread_id) ||
+		(p == NULL) ||
+		(p->enabled && (p->thread_id != thread_id)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'td->n_pipelines == 0'
#375: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:432:
+		if (softnic->params.sc && (td->n_pipelines == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#386: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:465:
+	if (softnic->params.sc && (n_pipelines == 0))

total: 0 errors, 1 warnings, 15 checks, 370 lines checked


More information about the test-report mailing list