[dpdk-test-report] |WARNING| pw56880 [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jul 22 15:07:41 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56880

_coding style issues_


WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#156: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65:
+	 */                                                                     \

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#179: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:88:
+#define __ATOMIC128_LDX_OP(ldx_op_name, op_string)                          \
+static inline rte_int128_t                                                  \
+ldx_op_name(const rte_int128_t *src)                                        \
+{                                                                           \
+	rte_int128_t ret;                                                       \
+	asm volatile(                                                           \
+			op_string " %0, %1, %2"                                         \
+			: "=&r" (ret.val[0]),                                           \
+			  "=&r" (ret.val[1])                                            \
+			: "Q" (src->val[0])                                             \
+			: "memory");                                                    \
+	return ret;                                                             \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#196: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:105:
+#define __ATOMIC128_STX_OP(stx_op_name, op_string)                          \
+static inline uint32_t                                                      \
+stx_op_name(rte_int128_t *dst, const rte_int128_t src)                      \
+{                                                                           \
+	uint32_t ret;                                                           \
+	asm volatile(                                                           \
+			op_string " %w0, %1, %2, %3"                                    \
+			: "=&r" (ret)                                                   \
+			: "r" (src.val[0]),                                             \
+			  "r" (src.val[1]),                                             \
+			  "Q" (dst->val[0])                                             \
+			: "memory");                                                    \
+	/* Return 0 on success, 1 on failure */                                 \
+	return ret;                                                             \
+}

total: 0 errors, 3 warnings, 261 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.


More information about the test-report mailing list