[dpdk-test-report] |WARNING| pw54476 [PATCH v4 03/11] net/hinic/base: add mgmt module interactive code

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 6 13:04:47 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54476

_coding style issues_


CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#83: FILE: drivers/net/hinic/base/hinic_pmd_hw_mgmt.h:43:
+	bool lro_en;    /* LRO feature enable bit */

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#164: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:33:
+#define SYNC_MSG_ID_INC(pf_to_mgmt)	(SYNC_MSG_ID(pf_to_mgmt) = \
+			(SYNC_MSG_ID(pf_to_mgmt) + 1) & SYNC_MSG_ID_MASK)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#169: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:38:
+#define ASYNC_MSG_ID_INC(pf_to_mgmt)	(ASYNC_MSG_ID(pf_to_mgmt) = \
+			((ASYNC_MSG_ID(pf_to_mgmt) + 1) & ASYNC_MSG_ID_MASK) \
+			| ASYNC_MSG_FLAG)

total: 0 errors, 0 warnings, 3 checks, 1330 lines checked


More information about the test-report mailing list