[dpdk-test-report] |WARNING| pw54588 [PATCH 08/29] net/sfc/base: add extensible NVRAM info function

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 13 15:53:50 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54588

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#60: FILE: drivers/net/sfc/base/efx_impl.h:571:
+efx_mcdi_nvram_info_ex(

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#65: FILE: drivers/net/sfc/base/efx_impl.h:576:
+	__checkReturn		efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#78: FILE: drivers/net/sfc/base/efx_nvram.c:660:
+efx_mcdi_nvram_info_ex(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#130: FILE: drivers/net/sfc/base/efx_nvram.c:722:
+efx_mcdi_nvram_info(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#141: FILE: drivers/net/sfc/base/efx_nvram.c:733:
+	if ((rc = efx_mcdi_nvram_info_ex(enp, partn, &eni)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#156: FILE: drivers/net/sfc/base/efx_nvram.c:748:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#161: FILE: drivers/net/sfc/base/efx_nvram.c:753:
+	return (rc);

total: 3 errors, 0 warnings, 4 checks, 120 lines checked


More information about the test-report mailing list