[dpdk-test-report] |WARNING| pw54608 [PATCH 29/29] net/sfc/base: add APIs for PTP privilege configuration

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54608

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#42: FILE: drivers/net/sfc/base/ef10_impl.h:1414:
+	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#43: FILE: drivers/net/sfc/base/ef10_impl.h:1415:
+ef10_proxy_auth_get_privilege_mask(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#60: FILE: drivers/net/sfc/base/ef10_proxy.c:454:
+ef10_proxy_auth_get_privilege_mask(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#66: FILE: drivers/net/sfc/base/ef10_proxy.c:460:
+	return (efx_mcdi_privilege_mask(enp, pf_index, vf_index, maskp));

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/net/sfc/base/efx.h:3517:
+efx_proxy_auth_privilege_mask_get(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#90: FILE: drivers/net/sfc/base/efx.h:3524:
+efx_proxy_auth_privilege_modify(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+	efx_rc_t	(*epo_get_privilege_mask)(efx_nic_t *, uint32_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+	efx_rc_t	(*epo_get_privilege_mask)(efx_nic_t *, uint32_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+	efx_rc_t	(*epo_get_privilege_mask)(efx_nic_t *, uint32_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+	efx_rc_t	(*epo_get_privilege_mask)(efx_nic_t *, uint32_t,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#138: FILE: drivers/net/sfc/base/efx_proxy.c:302:
+efx_proxy_auth_privilege_mask_get(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#158: FILE: drivers/net/sfc/base/efx_proxy.c:322:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/net/sfc/base/efx_proxy.c:328:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#168: FILE: drivers/net/sfc/base/efx_proxy.c:332:
+efx_proxy_auth_privilege_modify(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#191: FILE: drivers/net/sfc/base/efx_proxy.c:355:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#197: FILE: drivers/net/sfc/base/efx_proxy.c:361:
+	return (rc);

total: 5 errors, 4 warnings, 7 checks, 140 lines checked