[dpdk-test-report] |WARNING| pw54730 [PATCH v2 1/3] net/ice: enable switch filter

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54730

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#91: FILE: drivers/net/ice/ice_switch_filter.c:23:
+ice_parse_switch_filter(

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.eth_hdr.src_addr[j]'
#150: FILE: drivers/net/ice/ice_switch_filter.c:82:
+						list[t].h_u.eth_hdr.
+							src_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.eth_hdr.src_addr[j]'
#153: FILE: drivers/net/ice/ice_switch_filter.c:85:
+						list[t].m_u.eth_hdr.
+							src_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.eth_hdr.dst_addr[j]'
#159: FILE: drivers/net/ice/ice_switch_filter.c:91:
+						list[t].h_u.eth_hdr.
+							dst_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.eth_hdr.dst_addr[j]'
#162: FILE: drivers/net/ice/ice_switch_filter.c:94:
+						list[t].m_u.eth_hdr.
+							dst_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.src_addr[j]'
#232: FILE: drivers/net/ice/ice_switch_filter.c:164:
+						list[t].h_u.ice_ipv6_ofos_hdr.
+							src_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.src_addr[j]'
#235: FILE: drivers/net/ice/ice_switch_filter.c:167:
+						list[t].m_u.ice_ipv6_ofos_hdr.
+							src_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.dst_addr[j]'
#241: FILE: drivers/net/ice/ice_switch_filter.c:173:
+						list[t].h_u.ice_ipv6_ofos_hdr.
+							dst_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.dst_addr[j]'
#244: FILE: drivers/net/ice/ice_switch_filter.c:176:
+						list[t].m_u.ice_ipv6_ofos_hdr.
+							dst_addr[j] =

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.hop_limit'
#256: FILE: drivers/net/ice/ice_switch_filter.c:188:
+					list[t].h_u.ice_ipv6_ofos_hdr.
+					hop_limit = ipv6_spec->hdr.hop_limits;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.hop_limit'
#258: FILE: drivers/net/ice/ice_switch_filter.c:190:
+					list[t].m_u.ice_ipv6_ofos_hdr.
+						hop_limit  = UINT8_MAX;

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#399: FILE: drivers/net/ice/ice_switch_filter.c:331:
+/* By now ice switch filter action code implement only
+* supports QUEUE or DROP.

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#584: FILE: drivers/net/ice/ice_switch_filter.h:8:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#584: FILE: drivers/net/ice/ice_switch_filter.h:8:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#584: FILE: drivers/net/ice/ice_switch_filter.h:8:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#584: FILE: drivers/net/ice/ice_switch_filter.h:8:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#584: FILE: drivers/net/ice/ice_switch_filter.h:8:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

total: 0 errors, 11 warnings, 6 checks, 558 lines checked