[dpdk-test-report] |WARNING| pw55349 [PATCH v2 25/28] examples/qos_sched: update qos sched sample app

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jun 25 17:38:38 CEST 2019
Previous message: [dpdk-test-report] |WARNING| pw55348 [PATCH v2 24/28] net/softnic: update softnic tm function
Next message: [dpdk-test-report] |SUCCESS| pw55350 [PATCH v2 26/28] examples/ip_pipeline: update ip pipeline sample app
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55349

_coding style issues_


WARNING:LONG_LINE_COMMENT: line over 90 characters
#62: FILE: examples/qos_sched/app_thread.c:40:
+			(subport_params[*subport].n_subport_pipes - 1); /* Inner VLAN ID */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#65: FILE: examples/qos_sched/app_thread.c:43:
+			(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1) : *queue); /* Destination IP */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (32, 32)
#351: FILE: examples/qos_sched/cfg_file.c:230:
+				for (j = 0; j < RTE_SCHED_QUEUES_PER_PIPE; j++) {
+				subport_params[i].qsize[j] =

WARNING:LONG_LINE: line over 90 characters
#442: FILE: examples/qos_sched/init.c:173:
+		.tc_rate = {305175, 305175, 305175, 305175, 305175, 305175, 305175, 305175, 305175},

WARNING:LONG_LINE: line over 90 characters
#455: FILE: examples/qos_sched/init.c:188:
+		.tc_rate = {1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000},

WARNING:LONG_LINE: line over 90 characters
#460: FILE: examples/qos_sched/init.c:193:
+		.n_pipe_profiles = sizeof(pipe_profiles) / sizeof(struct rte_sched_pipe_params),

WARNING:LONG_LINE: line over 90 characters
#466: FILE: examples/qos_sched/init.c:199:
+			[0][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#467: FILE: examples/qos_sched/init.c:200:
+			[0][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#468: FILE: examples/qos_sched/init.c:201:
+			[0][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#471: FILE: examples/qos_sched/init.c:204:
+			[1][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#472: FILE: examples/qos_sched/init.c:205:
+			[1][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#473: FILE: examples/qos_sched/init.c:206:
+			[1][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#476: FILE: examples/qos_sched/init.c:209:
+			[2][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#477: FILE: examples/qos_sched/init.c:210:
+			[2][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#478: FILE: examples/qos_sched/init.c:211:
+			[2][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#481: FILE: examples/qos_sched/init.c:214:
+			[3][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#482: FILE: examples/qos_sched/init.c:215:
+			[3][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#483: FILE: examples/qos_sched/init.c:216:
+			[3][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#486: FILE: examples/qos_sched/init.c:219:
+			[4][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#487: FILE: examples/qos_sched/init.c:220:
+			[4][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#488: FILE: examples/qos_sched/init.c:221:
+			[4][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#491: FILE: examples/qos_sched/init.c:224:
+			[5][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#492: FILE: examples/qos_sched/init.c:225:
+			[5][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#493: FILE: examples/qos_sched/init.c:226:
+			[5][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#496: FILE: examples/qos_sched/init.c:229:
+			[6][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#497: FILE: examples/qos_sched/init.c:230:
+			[6][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#498: FILE: examples/qos_sched/init.c:231:
+			[6][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#501: FILE: examples/qos_sched/init.c:234:
+			[7][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#502: FILE: examples/qos_sched/init.c:235:
+			[7][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#503: FILE: examples/qos_sched/init.c:236:
+			[7][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#506: FILE: examples/qos_sched/init.c:239:
+			[8][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#507: FILE: examples/qos_sched/init.c:240:
+			[8][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#508: FILE: examples/qos_sched/init.c:241:
+			[8][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#843: FILE: examples/qos_sched/stats.c:25:
+	if (i == nb_pfc || subport_id >= port_params.n_subports_per_port ||
[...]
+			return -1;

WARNING:LONG_LINE: line over 90 characters
#935: FILE: examples/qos_sched/stats.c:92:
+				rte_sched_queue_read_stats(port, queue_id + i, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1084: FILE: examples/qos_sched/stats.c:175:
+		subport_queue_id += subport_params[i].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#1092: FILE: examples/qos_sched/stats.c:183:
+				queue_id = subport_queue_id + i * RTE_SCHED_QUEUES_PER_PIPE + tc;

WARNING:LONG_LINE: line over 90 characters
#1098: FILE: examples/qos_sched/stats.c:189:
+							i * RTE_SCHED_QUEUES_PER_PIPE + tc + j;

WARNING:LONG_LINE: line over 90 characters
#1099: FILE: examples/qos_sched/stats.c:190:
+					rte_sched_queue_read_stats(port, queue_id, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1106: FILE: examples/qos_sched/stats.c:197:
+			average += part_average / (subport_params[subport_id].n_subport_pipes);

WARNING:LONG_LINE: line over 90 characters
#1108: FILE: examples/qos_sched/stats.c:199:
+			average += part_average / (subport_params[subport_id].n_subport_pipes) * RTE_SCHED_BE_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#1153: FILE: examples/qos_sched/stats.c:232:
+		subport_queue_id += subport_params[i].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#1173: FILE: examples/qos_sched/stats.c:242:
+				rte_sched_queue_read_stats(port, queue_id + j, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1181: FILE: examples/qos_sched/stats.c:247:
+		average += part_average / (subport_params[subport_id].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE);

WARNING:LONG_LINE: line over 90 characters
#1247: FILE: examples/qos_sched/stats.c:285:
+		printf("|  %d | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " |
", i,

WARNING:LONG_LINE: line over 90 characters
#1328: FILE: examples/qos_sched/stats.c:328:
+			printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, 0,

WARNING:LONG_LINE: line over 90 characters
#1329: FILE: examples/qos_sched/stats.c:329:
+				stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

WARNING:LONG_LINE: line over 90 characters
#1333: FILE: examples/qos_sched/stats.c:333:
+				rte_sched_queue_read_stats(port, queue_id + i + j, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1334: FILE: examples/qos_sched/stats.c:334:
+				printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, j,

WARNING:LONG_LINE: line over 90 characters
#1335: FILE: examples/qos_sched/stats.c:335:
+					stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

total: 0 errors, 50 warnings, 1253 lines checked
Previous message: [dpdk-test-report] |WARNING| pw55348 [PATCH v2 24/28] net/softnic: update softnic tm function
Next message: [dpdk-test-report] |SUCCESS| pw55350 [PATCH v2 26/28] examples/ip_pipeline: update ip pipeline sample app
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list