[dpdk-test-report] |WARNING| pw50724 test: add new test structure for asymmetric cryptography

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 1 17:39:48 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50724

_coding style issues_


ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream.
#21: 
Change-Id: I01de09e65565a4ab3547fbff8c9d1e5f3d2bed1f

ERROR:SPACING: space required after that close brace '}'
#65: FILE: test/test/test_cryptodev_asym.c:59:
+static struct test_cases_array test_vector = {0, {NULL}};

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#80: FILE: test/test/test_cryptodev_asym.c:74:
+	switch (test_case_data->modex.xform_type) {
+		case RTE_CRYPTO_ASYM_XFORM_MODEX:
[...]
+		case RTE_CRYPTO_ASYM_XFORM_MODINV:
[...]
+		case RTE_CRYPTO_ASYM_XFORM_DH:
+		case RTE_CRYPTO_ASYM_XFORM_DSA:
+		case RTE_CRYPTO_ASYM_XFORM_RSA:
+		case RTE_CRYPTO_ASYM_XFORM_NONE:
+		case RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED:
+		default:

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#143: FILE: test/test/test_cryptodev_asym.c:137:
+	switch (xform_tc.xform_type) {
+		case RTE_CRYPTO_ASYM_XFORM_MODEX:
[...]
+		case RTE_CRYPTO_ASYM_XFORM_MODINV:
[...]
+		case RTE_CRYPTO_ASYM_XFORM_DH:
+		case RTE_CRYPTO_ASYM_XFORM_DSA:
+		case RTE_CRYPTO_ASYM_XFORM_RSA:
+		case RTE_CRYPTO_ASYM_XFORM_NONE:
+		case RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED:
+		default:

WARNING:LONG_LINE: line over 90 characters
#147: FILE: test/test/test_cryptodev_asym.c:141:
+			xform_tc.modex.exponent.data = test_case_data->modex.exponent.data;

WARNING:LONG_LINE: line over 90 characters
#148: FILE: test/test/test_cryptodev_asym.c:142:
+			xform_tc.modex.exponent.length = test_case_data->modex.exponent.len;

WARNING:LONG_LINE: line over 90 characters
#149: FILE: test/test/test_cryptodev_asym.c:143:
+			memcpy(input, test_case_data->modex.base.data, test_case_data->modex.base.len);

WARNING:LONG_LINE: line over 90 characters
#163: FILE: test/test/test_cryptodev_asym.c:157:
+			xform_tc.modinv.modulus.data = test_case_data->modinv.modulus.data;

WARNING:LONG_LINE: line over 90 characters
#164: FILE: test/test/test_cryptodev_asym.c:158:
+			xform_tc.modinv.modulus.length = test_case_data->modinv.modulus.len;

WARNING:LONG_LINE: line over 90 characters
#165: FILE: test/test/test_cryptodev_asym.c:159:
+			memcpy(input, test_case_data->modinv.base.data, test_case_data->modinv.base.len);

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#190: FILE: test/test/test_cryptodev_asym.c:184:
+			goto error_exit;
+			break;

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(modex_test_case)
#281: FILE: test/test/test_cryptodev_asym.c:275:
+	v_size = sizeof(modex_test_case)/sizeof(modex_test_case[0]);

ERROR:SPACING: space required before the open brace '{'
#282: FILE: test/test/test_cryptodev_asym.c:276:
+	for (i = 0; i < v_size; i++){

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#287: FILE: test/test/test_cryptodev_asym.c:281:
+			return -1;
+		} else {

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(modinv_test_case)
#294: FILE: test/test/test_cryptodev_asym.c:288:
+	v_size = sizeof(modinv_test_case)/sizeof(modinv_test_case[0]);

ERROR:SPACING: space required before the open brace '{'
#295: FILE: test/test/test_cryptodev_asym.c:289:
+	for (i = 0; i < v_size; i++){

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#300: FILE: test/test/test_cryptodev_asym.c:294:
+			return -1;
+		} else {

ERROR:SPACING: space required before the open brace '{'
#317: FILE: test/test/test_cryptodev_asym.c:311:
+	for (i = 0; i < test_vector.size; i++){

ERROR:SPACING: space required before the open parenthesis '('
#318: FILE: test/test/test_cryptodev_asym.c:312:
+		if(test_one_case(test_vector.address[i]) != TEST_SUCCESS)

total: 8 errors, 11 warnings, 1262 lines checked


More information about the test-report mailing list