[dpdk-test-report] |WARNING| pw51275 [PATCH v2 2/4] crypto/qat: add asymmetric cryptography PMD

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Mar 18 13:47:30 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/51275

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#203: FILE: drivers/crypto/qat/qat_asym.c:14:
+static int __rte_unused qat_asym_get_sz_and_func_id(const uint32_t arr[][2],
+		size_t arr_sz, size_t *size, uint32_t *func_id) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#217: FILE: drivers/crypto/qat/qat_asym.c:28:
+static void qat_asym_build_req_tmpl(void *sess_private_data,
+		struct rte_crypto_asym_xform __rte_unused *xform) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#260: FILE: drivers/crypto/qat/qat_asym.c:71:
+static void __rte_unused qat_clear_arrays(struct qat_asym_op_cookie *cookie, int in_count,
+		int out_count, int in_size, int out_size) {

WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'?
#273: FILE: drivers/crypto/qat/qat_asym.c:84:
+		 * generator which very often can be of one byte lenght */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#273: FILE: drivers/crypto/qat/qat_asym.c:84:
+		 * generator which very often can be of one byte lenght */

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#564: FILE: drivers/crypto/qat/qat_asym_pmd.c:23:
+int

WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/crypto/qat/qat_asym_pmd.c:182:
+					offsetof(struct qat_asym_op_cookie, input_array[j]);

WARNING:LONG_LINE: line over 90 characters
#725: FILE: drivers/crypto/qat/qat_asym_pmd.c:184:
+					offsetof(struct qat_asym_op_cookie, output_array[j]);

total: 3 errors, 5 warnings, 807 lines checked


More information about the test-report mailing list