[dpdk-test-report] |WARNING| pw53966 [RFC 4/5] app/testpmd: macsec: update set sc command with new interface

checkpatch at dpdk.org checkpatch at dpdk.org
Fri May 31 18:16:17 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53966

_coding style issues_


ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#27: 
--- a/app/test-pmd/cmdline.c

ERROR:DOS_LINE_ENDINGS: DOS line endings
#33: FILE: app/test-pmd/cmdline.c:14086:
+^Imacsec_conf.macsec.^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#41: FILE: app/test-pmd/cmdline.c:14284:
+^Istruct rte_security_ctx *ctx;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#42: FILE: app/test-pmd/cmdline.c:14285:
+^Istruct rte_eth_dev_info dev_info;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#43: FILE: app/test-pmd/cmdline.c:14286:
+^Istruct rte_security_session_conf conf = {};^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#53: FILE: app/test-pmd/cmdline.c:14288:
+^Ictx = rte_eth_dev_get_sec_ctx(port_id);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#54: FILE: app/test-pmd/cmdline.c:14289:
+^Iif (!ctx) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#55: FILE: app/test-pmd/cmdline.c:14290:
+^I^Iret = ENOTSUP;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: app/test-pmd/cmdline.c:14291:
+^I^Igoto done;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#57: FILE: app/test-pmd/cmdline.c:14292:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#58: FILE: app/test-pmd/cmdline.c:14293:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#59: FILE: app/test-pmd/cmdline.c:14294:
+^Iif (is_tx) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#60: FILE: app/test-pmd/cmdline.c:14295:
+^I^Iconf.macsec.op = RTE_SECURITY_MACSEC_OP_ADD_TXSC;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#61: FILE: app/test-pmd/cmdline.c:14296:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#62: FILE: app/test-pmd/cmdline.c:14297:
+^I^Irte_memcpy(&conf.macsec.txsc_options.s_mac, res->mac.addr_bytes,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#63: FILE: app/test-pmd/cmdline.c:14298:
+^I^I^Isizeof(struct ether_addr));^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#64: FILE: app/test-pmd/cmdline.c:14299:
+^I^Iconf.macsec.txsc_options.encrypt = macsec_encrypt;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#65: FILE: app/test-pmd/cmdline.c:14300:
+^I^Iconf.macsec.txsc_options.protect = 1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#66: FILE: app/test-pmd/cmdline.c:14301:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#67: FILE: app/test-pmd/cmdline.c:14302:
+^I^Iret = rte_security_session_update(ctx, macsec_session, &conf);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#68: FILE: app/test-pmd/cmdline.c:14303:
+^I} else {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: app/test-pmd/cmdline.c:14304:
+^I^Iconf.macsec.op = RTE_SECURITY_MACSEC_OP_ADD_RXSC;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#70: FILE: app/test-pmd/cmdline.c:14305:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#71: FILE: app/test-pmd/cmdline.c:14306:
+^I^Irte_memcpy(&conf.macsec.rxsc_options.s_mac, res->mac.addr_bytes,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#72: FILE: app/test-pmd/cmdline.c:14307:
+^I^I^Isizeof(struct ether_addr));^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: app/test-pmd/cmdline.c:14308:
+^I^I/* Default */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#74: FILE: app/test-pmd/cmdline.c:14309:
+^I^Iconf.macsec.rxsc_options.anti_replay_window = 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#75: FILE: app/test-pmd/cmdline.c:14310:
+^I^Iconf.macsec.rxsc_options.replay_protection = macsec_replay_protection;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#76: FILE: app/test-pmd/cmdline.c:14311:
+^I^Iconf.macsec.rxsc_options.auto_rollover_enabled = true;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#77: FILE: app/test-pmd/cmdline.c:14312:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: app/test-pmd/cmdline.c:14313:
+^I^Iret = rte_security_session_update(ctx, macsec_session, &conf);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#79: FILE: app/test-pmd/cmdline.c:14314:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#80: FILE: app/test-pmd/cmdline.c:14315:
+^I}^M$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 34 errors, 0 warnings, 53 lines checked


More information about the test-report mailing list