[dpdk-test-report] |WARNING| pw63124 [PATCH] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63124

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#72: 
Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 

WARNING:TYPO_SPELLING: 'psuedo' may be misspelled - perhaps 'pseudo'?
#74: 
that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set.

WARNING:BAD_SIGN_OFF: Non-standard signature: Co-Authored-By:
#82: 
Co-Authored-By: Valentin Andrei <vandrei at fb.com>

WARNING:BAD_SIGN_OFF: 'Co-authored-by:' is the preferred signature form
#82: 
Co-Authored-By: Valentin Andrei <vandrei at fb.com>

WARNING:LONG_LINE: line over 90 characters
#141: FILE: app/cli-functions.c:533:
+			ip_ver = _atoip(argv[4], PG_IPADDR_V4 | PG_IPADDR_NETWORK, &ip, sizeof(ip));

ERROR:CODE_INDENT: code indent should use tabs where possible
#248: FILE: app/lpktgenlib.c:667:
+^I             single_set_ipaddr(info, type[0], &ipaddr, ip_ver) );$

ERROR:SPACING: space prohibited before that close parenthesis ')'
#248: FILE: app/lpktgenlib.c:667:
+	             single_set_ipaddr(info, type[0], &ipaddr, ip_ver) );

WARNING:LONG_LINE: line over 90 characters
#261: FILE: app/pktgen-cmds.c:177:
+			inet_ntop6(buff, sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#267: FILE: app/pktgen-cmds.c:183:
+			inet_ntop6(buff, sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#276: FILE: app/pktgen-cmds.c:378:
+				inet_ntop6(buff, sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#283: FILE: app/pktgen-cmds.c:385:
+				inet_ntop6(buff, sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#292: FILE: app/pktgen-cmds.c:549:
+			inet_ntop6(buff, sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#298: FILE: app/pktgen-cmds.c:555:
+			inet_ntop6(buff, sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#307: FILE: app/pktgen-cmds.c:745:
+					inet_ntop6(buff, sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#314: FILE: app/pktgen-cmds.c:752:
+					inet_ntop6(buff, sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#323: FILE: app/pktgen-cmds.c:782:
+					inet_ntop6(buff, sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr) :

WARNING:LONG_LINE: line over 90 characters
#329: FILE: app/pktgen-cmds.c:788:
+					inet_ntop6(buff, sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr) :

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#338: FILE: app/pktgen-cmds.c:3060:
+single_set_ipaddr(port_info_t* info, char type, struct pg_ipaddr* ip,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#338: FILE: app/pktgen-cmds.c:3060:
+single_set_ipaddr(port_info_t* info, char type, struct pg_ipaddr* ip,

WARNING:LONG_LINE: line over 90 characters
#347: FILE: app/pktgen-cmds.c:3066:
+										ip->ipv4.s_addr);

WARNING:LONG_LINE: line over 90 characters
#351: FILE: app/pktgen-cmds.c:3069:
+										ip->ipv4.s_addr);

ERROR:SPACING: space required before the open brace '{'
#355: FILE: app/pktgen-cmds.c:3073:
+	} else if (type == 'd' && ip_ver == 6){

WARNING:LONG_LINE: line over 90 characters
#419: FILE: app/pktgen-stats.c:173:
+					sizeof(buff), pkt->ip_dst_addr.addr.ipv6.s6_addr));

WARNING:LONG_LINE: line over 90 characters
#421: FILE: app/pktgen-stats.c:175:
+					sizeof(buff), pkt->ip_src_addr.addr.ipv6.s6_addr));

WARNING:LONG_LINE: line over 90 characters
#424: FILE: app/pktgen-stats.c:178:
+					sizeof(buff), htonl(pkt->ip_dst_addr.addr.ipv4.s_addr), 0xFFFFFFFF));

WARNING:LONG_LINE: line over 90 characters
#426: FILE: app/pktgen-stats.c:180:
+					sizeof(buff), htonl(pkt->ip_src_addr.addr.ipv4.s_addr), pkt->ip_mask));

total: 5 errors, 21 warnings, 399 lines checked