[dpdk-test-report] |WARNING| pw58546 [PATCH 2/4] net/ice: rework for generic flow enabling

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 4 08:37:35 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/58546

_coding style issues_


WARNING:TYPO_SPELLING: 'swith' may be misspelled - perhaps 'switch'?
#152: FILE: drivers/net/ice/ice_generic_flow.c:22:
+ * Non-pipeline mode, fdir and swith both used as distributor,

CHECK:BRACES: braces {} should be used on all arms of this statement
#272: FILE: drivers/net/ice/ice_generic_flow.c:151:
+	if (ad->devargs.pipeline_mode_support)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#274: FILE: drivers/net/ice/ice_generic_flow.c:153:
+	else {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#276: FILE: drivers/net/ice/ice_generic_flow.c:155:
+		if (parser->engine->type == ICE_FLOW_ENGINE_SWITCH
+			|| parser->engine->type == ICE_FLOW_ENGINE_HASH)

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#314: FILE: drivers/net/ice/ice_generic_flow.c:193:
+
+}

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#338: FILE: drivers/net/ice/ice_generic_flow.c:217:
+		if (0 == attr->priority)

CHECK:BRACES: Unbalanced braces around else statement
#1002: FILE: drivers/net/ice/ice_generic_flow.c:533:
+	} else

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1853: FILE: drivers/net/ice/ice_generic_flow.h:177:
+ice_search_pattern_match_item(

total: 0 errors, 2 warnings, 6 checks, 1811 lines checked


More information about the test-report mailing list