[dpdk-test-report] |WARNING| pw59004 [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Sep 9 14:00:37 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59004

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1299: FILE: drivers/net/i40e/i40e_vf_representor.c:282:
+	return rte_pmd_i40e_set_vf_unicast_promisc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1311: FILE: drivers/net/i40e/i40e_vf_representor.c:292:
+	return rte_pmd_i40e_set_vf_unicast_promisc(

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#2073: FILE: drivers/net/netvsc/hn_vf.c:366:
+#define VF_ETHDEV_FUNC_RET_STATUS(dev, func)			\
+	{							\
+		struct hn_data *hv = (dev)->data->dev_private;	\
+		struct rte_eth_dev *vf_dev;			\
+		int ret = 0;					\
+		rte_spinlock_lock(&hv->vf_lock);		\
+		vf_dev = hn_get_vf_dev(hv);			\
+		if (vf_dev)					\
+			ret = func(vf_dev->data->port_id);	\
+		rte_spinlock_unlock(&hv->vf_lock);		\
+		return ret;					\
+	}

total: 0 errors, 1 warnings, 2301 lines checked


More information about the test-report mailing list