[dpdk-test-report] |WARNING| pw59473 [PATCH v2 3/4] net/bnx2x: update to latest FW 7.13.11

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 19 23:15:42 CEST 2019

Previous message: [dpdk-test-report] |SUCCESS| pw59472 [PATCH v2 4/4] doc: cleanup SPDX license id usage in bnx2x guide
Next message: [dpdk-test-report] |SUCCESS| pw59474 [PATCH v2 1/4] net/bnx2x: update and reorganize HW registers
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59473

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <assertListEntry>
#197: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18:
+	(IRO[151].base + ((assertListEntry) * IRO[151].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#201: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+	(IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
 	                         ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#201: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+	(IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
 	                                                       ^

CHECK:CAMELCASE: Avoid CamelCase: <pfId>
#201: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+	(IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#212: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+	(IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
 	                         ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#212: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+	(IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
 	                                                       ^

CHECK:CAMELCASE: Avoid CamelCase: <funcId>
#216: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26:
+	(IRO[163].base + ((funcId) * IRO[163].m1))

CHECK:CAMELCASE: Avoid CamelCase: <hcIndex>
#222: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+	(IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:CAMELCASE: Avoid CamelCase: <sbId>
#222: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+	(IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#227: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+	(IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \
 	                            ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#227: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+	(IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \
 	                                                             ^

CHECK:CAMELCASE: Avoid CamelCase: <iscsiEqId>
#238: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40:
+	(IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2))

CHECK:CAMELCASE: Avoid CamelCase: <vfId>
#310: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87:
+#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \

CHECK:CAMELCASE: Avoid CamelCase: <portId>
#391: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142:
+	(IRO[187].base + ((portId) * IRO[187].m1))

CHECK:CAMELCASE: Avoid CamelCase: <clientId>
#437: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172:
+	(IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \

CHECK:CAMELCASE: Avoid CamelCase: <qzoneId>
#443: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175:
+	(IRO[216].base + ((qzoneId) * IRO[216].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#521: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+	(IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
 	                         ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#521: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+	(IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
 	                                                       ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#549: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+	(0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
 	                     ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#549: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+	(0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
 	                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#549: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+	(0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
 	                                                    ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#553: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                       ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#553: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#557: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276:
+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1)
                                                      ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#600: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378:
+#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6))
                                            ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order == MAX_RD_ORD'
#1142: FILE: drivers/net/bnx2x/ecore_init_ops.h:499:
+	if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1560: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)				\
 	do {								\
 		x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \
 		if (x) {						\
 			if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,	\
 					  size, (struct bnx2x_dma *)x,	\
+					  "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
 				rte_free(x);				\
 				x = NULL;				\
+				*(y) = 0;				\
 			} else {					\
 				*y = ((struct bnx2x_dma *)x)->paddr;	\
 			}						\

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#1560: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)				\
 	do {								\
 		x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \
 		if (x) {						\
 			if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,	\
 					  size, (struct bnx2x_dma *)x,	\
+					  "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
 				rte_free(x);				\
 				x = NULL;				\
+				*(y) = 0;				\
 			} else {					\
 				*y = ((struct bnx2x_dma *)x)->paddr;	\
 			}						\

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#2214: FILE: drivers/net/bnx2x/ecore_sp.h:1967:
+#define PF_MAC_CREDIT_E2(sc, func_num)					\
+	((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \
+	 (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#2218: FILE: drivers/net/bnx2x/ecore_sp.h:1971:
+#define PF_VLAN_CREDIT_E2(sc, func_num)					 \
+	((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_VLAN_CREDIT_CNT) / \
+	 (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_VLAN_CREDIT_CNT)

total: 0 errors, 0 warnings, 30 checks, 2020 lines checked

Previous message: [dpdk-test-report] |SUCCESS| pw59472 [PATCH v2 4/4] doc: cleanup SPDX license id usage in bnx2x guide
Next message: [dpdk-test-report] |SUCCESS| pw59474 [PATCH v2 1/4] net/bnx2x: update and reorganize HW registers
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the test-report mailing list