[dpdk-test-report] |WARNING| pw67576 [PATCH] net/dpdkoin: add new driver

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Apr 1 15:11:51 CEST 2020
Previous message: [dpdk-test-report] |FAILURE| pw67575 [PATCH] [v2] ethdev: fix for compiler warning when vtune profiling option is enabled
Next message: [dpdk-test-report] |SUCCESS| pw67577 [PATCH 1/2] test/malloc: run realloc tests on external heap
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67576

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#99: 
  PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#258: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:17:
+static unsigned default_packet_size = 64;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#259: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:18:
+static unsigned default_packet_copy;

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#263: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:22:
+static const char *valid_arguments[] = {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#282: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:41:
+	unsigned packet_size;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#283: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:42:
+	unsigned packet_copy;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#319: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:78:
+	unsigned packet_size;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'q == NULL'
#321: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:80:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'bufs == NULL'
#321: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:80:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around h->rx_pkts
#334: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:93:
+	rte_atomic64_add(&(h->rx_pkts), i);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#346: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:105:
+	unsigned packet_size;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'q == NULL'
#348: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:107:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'bufs == NULL'
#348: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:107:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around h->rx_pkts
#363: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:122:
+	rte_atomic64_add(&(h->rx_pkts), i);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'q == NULL'
#376: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:135:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'bufs == NULL'
#376: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:135:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around h->tx_pkts
#382: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:141:
+	rte_atomic64_add(&(h->tx_pkts), i);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#394: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:153:
+	unsigned packet_size;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'q == NULL'
#396: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:155:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'bufs == NULL'
#396: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:155:
+	if ((q == NULL) || (bufs == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around h->tx_pkts
#406: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:165:
+	rte_atomic64_add(&(h->tx_pkts), i);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#448: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:207:
+	unsigned packet_size;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev == NULL'
#450: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:209:
+	if ((dev == NULL) || (mb_pool == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mb_pool == NULL'
#450: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:209:
+	if ((dev == NULL) || (mb_pool == NULL))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#482: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:241:
+	unsigned packet_size;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev == NULL'
#519: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:278:
+	if ((dev == NULL) || (dev_info == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_info == NULL'
#519: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:278:
+	if ((dev == NULL) || (dev_info == NULL))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#537: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:296:
+	unsigned i, num_stats;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev == NULL'
#541: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:300:
+	if ((dev == NULL) || (igb_stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'igb_stats == NULL'
#541: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:300:
+	if ((dev == NULL) || (igb_stats == NULL))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#545: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:304:
+	num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#554: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:313:
+	num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#572: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:331:
+	unsigned i;

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#599: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:358:
+static int
+eth_link_update(struct rte_eth_dev *dev __rte_unused,
+		int wait_to_complete __rte_unused) { return 0; }

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#717: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:476:
+		unsigned packet_size,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#718: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:477:
+		unsigned packet_copy)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#720: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:479:
+	const unsigned nb_rx_queues = 1;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#721: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:480:
+	const unsigned nb_tx_queues = 1;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#750: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:509:
+	 * so the dpdkoins are local per-process */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#794: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:553:
+	unsigned *packet_size = extra_args;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'value == NULL'
#796: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:555:
+	if ((value == NULL) || (extra_args == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'extra_args == NULL'
#796: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:555:
+	if ((value == NULL) || (extra_args == NULL))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#799: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:558:
+	*packet_size = (unsigned)strtoul(a, NULL, 0);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#811: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:570:
+	unsigned *packet_copy = extra_args;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'value == NULL'
#813: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:572:
+	if ((value == NULL) || (extra_args == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'extra_args == NULL'
#813: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:572:
+	if ((value == NULL) || (extra_args == NULL))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#816: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:575:
+	*packet_copy = (unsigned)strtoul(a, NULL, 0);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#827: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:586:
+	unsigned packet_size = default_packet_size;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#828: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:587:
+	unsigned packet_copy = default_packet_copy;

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#866: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:625:
+		if (rte_kvargs_count(kvlist, ETH_DPDKOIN_PACKET_SIZE_ARG) == 1) {
+

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#875: FILE: drivers/net/dpdkoin/rte_eth_dpdkoin.c:634:
+		if (rte_kvargs_count(kvlist, ETH_DPDKOIN_PACKET_COPY_ARG) == 1) {
+

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 26 warnings, 750 lines checked
Previous message: [dpdk-test-report] |FAILURE| pw67575 [PATCH] [v2] ethdev: fix for compiler warning when vtune profiling option is enabled
Next message: [dpdk-test-report] |SUCCESS| pw67577 [PATCH 1/2] test/malloc: run realloc tests on external heap
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list