[dpdk-test-report] |WARNING| pw67652 [PATCH v2 1/5] net/iavf: add support for FDIR basic rule

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 2 15:35:46 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67652

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#203: FILE: drivers/net/iavf/iavf_fdir.c:71:
+	{iavf_pattern_ethertype,		IAVF_FDIR_INSET_ETH,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#204: FILE: drivers/net/iavf/iavf_fdir.c:72:
+	{iavf_pattern_eth_ipv4,			IAVF_FDIR_INSET_ETH_IPV4,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#205: FILE: drivers/net/iavf/iavf_fdir.c:73:
+	{iavf_pattern_eth_ipv4_udp,		IAVF_FDIR_INSET_ETH_IPV4_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#206: FILE: drivers/net/iavf/iavf_fdir.c:74:
+	{iavf_pattern_eth_ipv4_tcp,		IAVF_FDIR_INSET_ETH_IPV4_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#207: FILE: drivers/net/iavf/iavf_fdir.c:75:
+	{iavf_pattern_eth_ipv4_sctp,		IAVF_FDIR_INSET_ETH_IPV4_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#208: FILE: drivers/net/iavf/iavf_fdir.c:76:
+	{iavf_pattern_eth_ipv6,			IAVF_FDIR_INSET_ETH_IPV6,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#209: FILE: drivers/net/iavf/iavf_fdir.c:77:
+	{iavf_pattern_eth_ipv6_udp,		IAVF_FDIR_INSET_ETH_IPV6_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#210: FILE: drivers/net/iavf/iavf_fdir.c:78:
+	{iavf_pattern_eth_ipv6_tcp,		IAVF_FDIR_INSET_ETH_IPV6_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#211: FILE: drivers/net/iavf/iavf_fdir.c:79:
+	{iavf_pattern_eth_ipv6_sctp,		IAVF_FDIR_INSET_ETH_IPV6_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#406: FILE: drivers/net/iavf/iavf_fdir.c:274:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#416: FILE: drivers/net/iavf/iavf_fdir.c:284:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#427: FILE: drivers/net/iavf/iavf_fdir.c:295:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#446: FILE: drivers/net/iavf/iavf_fdir.c:314:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#646: FILE: drivers/net/iavf/iavf_fdir.c:514:
+					== rte_cpu_to_be_32(

WARNING:LONG_LINE: line over 90 characters
#657: FILE: drivers/net/iavf/iavf_fdir.c:525:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, HOP_LIMIT);

WARNING:LONG_LINE: line over 90 characters
#699: FILE: drivers/net/iavf/iavf_fdir.c:567:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#703: FILE: drivers/net/iavf/iavf_fdir.c:571:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#743: FILE: drivers/net/iavf/iavf_fdir.c:611:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#747: FILE: drivers/net/iavf/iavf_fdir.c:615:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#781: FILE: drivers/net/iavf/iavf_fdir.c:649:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#785: FILE: drivers/net/iavf/iavf_fdir.c:653:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, DST_PORT);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#948: FILE: drivers/net/iavf/iavf_vchnl.c:958:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#995: FILE: drivers/net/iavf/iavf_vchnl.c:1005:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1039: FILE: drivers/net/iavf/iavf_vchnl.c:1049:
+		return -1;
+	} else {

total: 0 errors, 23 warnings, 1 checks, 957 lines checked


More information about the test-report mailing list