[dpdk-test-report] |WARNING| pw67740 [PATCH v2] net/axgbe: vlan support enabling in axgbe

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 3 08:20:58 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67740

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#172: FILE: drivers/net/axgbe/axgbe_common.h:295:
+#define VLAN_TABLE_BIT(vlan_id)	((unsigned long)1 << ((vlan_id) & 0x3F))

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#660: FILE: drivers/net/axgbe/axgbe_ethdev.h:295:
+	int (*enable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#661: FILE: drivers/net/axgbe/axgbe_ethdev.h:296:
+	int (*disable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#662: FILE: drivers/net/axgbe/axgbe_ethdev.h:297:
+	int (*enable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#663: FILE: drivers/net/axgbe/axgbe_ethdev.h:298:
+	int (*disable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#664: FILE: drivers/net/axgbe/axgbe_ethdev.h:299:
+	int (*update_vlan_hash_table)(struct axgbe_port *);

total: 0 errors, 6 warnings, 0 checks, 529 lines checked


More information about the test-report mailing list