[dpdk-test-report] |WARNING| pw67928 [PATCH v3 3/7] net/virtio: add vectorized packed ring Rx function

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Apr 8 03:19:44 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67928

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#161: FILE: drivers/net/virtio/virtio_rxtx.c:2332:
+virtio_recv_pkts_packed_vec(void __rte_unused *rx_queue,
                                               ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#162: FILE: drivers/net/virtio/virtio_rxtx.c:2333:
+			    struct rte_mbuf __rte_unused **rx_pkts,
 			                                 ^

CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#197: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#197: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#197: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#197: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#202: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#202: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#202: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#207: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#207: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#207: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#212: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#212: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

total: 3 errors, 0 warnings, 11 checks, 452 lines checked


More information about the test-report mailing list