[dpdk-test-report] |WARNING| pw68983 [PATCH v5 1/5] net/iavf: add support for FDIR basic rule

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Apr 21 08:25:26 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68983

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#218: FILE: drivers/net/iavf/iavf_fdir.c:71:
+	{iavf_pattern_ethertype,		IAVF_FDIR_INSET_ETH,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#219: FILE: drivers/net/iavf/iavf_fdir.c:72:
+	{iavf_pattern_eth_ipv4,			IAVF_FDIR_INSET_ETH_IPV4,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#220: FILE: drivers/net/iavf/iavf_fdir.c:73:
+	{iavf_pattern_eth_ipv4_udp,		IAVF_FDIR_INSET_ETH_IPV4_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#221: FILE: drivers/net/iavf/iavf_fdir.c:74:
+	{iavf_pattern_eth_ipv4_tcp,		IAVF_FDIR_INSET_ETH_IPV4_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#222: FILE: drivers/net/iavf/iavf_fdir.c:75:
+	{iavf_pattern_eth_ipv4_sctp,		IAVF_FDIR_INSET_ETH_IPV4_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#223: FILE: drivers/net/iavf/iavf_fdir.c:76:
+	{iavf_pattern_eth_ipv6,			IAVF_FDIR_INSET_ETH_IPV6,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#224: FILE: drivers/net/iavf/iavf_fdir.c:77:
+	{iavf_pattern_eth_ipv6_udp,		IAVF_FDIR_INSET_ETH_IPV6_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#225: FILE: drivers/net/iavf/iavf_fdir.c:78:
+	{iavf_pattern_eth_ipv6_tcp,		IAVF_FDIR_INSET_ETH_IPV6_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#226: FILE: drivers/net/iavf/iavf_fdir.c:79:
+	{iavf_pattern_eth_ipv6_sctp,		IAVF_FDIR_INSET_ETH_IPV6_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#420: FILE: drivers/net/iavf/iavf_fdir.c:273:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#430: FILE: drivers/net/iavf/iavf_fdir.c:283:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#441: FILE: drivers/net/iavf/iavf_fdir.c:294:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#460: FILE: drivers/net/iavf/iavf_fdir.c:313:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#670: FILE: drivers/net/iavf/iavf_fdir.c:523:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, HOP_LIMIT);

WARNING:LONG_LINE: line over 90 characters
#712: FILE: drivers/net/iavf/iavf_fdir.c:565:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#716: FILE: drivers/net/iavf/iavf_fdir.c:569:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#756: FILE: drivers/net/iavf/iavf_fdir.c:609:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#760: FILE: drivers/net/iavf/iavf_fdir.c:613:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#794: FILE: drivers/net/iavf/iavf_fdir.c:647:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#798: FILE: drivers/net/iavf/iavf_fdir.c:651:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, DST_PORT);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#965: FILE: drivers/net/iavf/iavf_vchnl.c:911:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1012: FILE: drivers/net/iavf/iavf_vchnl.c:958:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1056: FILE: drivers/net/iavf/iavf_vchnl.c:1002:
+		return -1;
+	} else {

total: 0 errors, 23 warnings, 0 checks, 964 lines checked


More information about the test-report mailing list