[dpdk-test-report] |WARNING| pw84818 [PATCH v1 2/2] linux/kni: Added support for KNI multiple fifos

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 8 11:07:30 CET 2020
Previous message (by thread): [dpdk-test-report] |SUCCESS| pw84817 [PATCH] net/e1000: fix incorrect return value if filter type not supported.
Next message (by thread): [dpdk-test-report] |SUCCESS| pw84786 net/e1000: fix incorrect return value if filter type not supported.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/84818

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#172: FILE: kernel/linux/kni/kni_dev.h:90:
+	unsigned queues_num;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#173: FILE: kernel/linux/kni/kni_dev.h:91:
+	unsigned fifos_num;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#192: FILE: kernel/linux/kni/kni_fifo.h:25:
+kni_mp_fifo_put(struct rte_kni_fifo *fifo, void **data, unsigned n)

ERROR:CODE_INDENT: code indent should use tabs where possible
#198: FILE: kernel/linux/kni/kni_fifo.h:27:
+        unsigned fifo_write, new_write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: kernel/linux/kni/kni_fifo.h:27:
+        unsigned fifo_write, new_write;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#198: FILE: kernel/linux/kni/kni_fifo.h:27:
+        unsigned fifo_write, new_write;

ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: kernel/linux/kni/kni_fifo.h:28:
+        unsigned fifo_read, free_entries;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: kernel/linux/kni/kni_fifo.h:28:
+        unsigned fifo_read, free_entries;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#199: FILE: kernel/linux/kni/kni_fifo.h:28:
+        unsigned fifo_read, free_entries;

ERROR:CODE_INDENT: code indent should use tabs where possible
#200: FILE: kernel/linux/kni/kni_fifo.h:29:
+        const unsigned max = n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: kernel/linux/kni/kni_fifo.h:29:
+        const unsigned max = n;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#200: FILE: kernel/linux/kni/kni_fifo.h:29:
+        const unsigned max = n;

ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: kernel/linux/kni/kni_fifo.h:30:
+        int success = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: kernel/linux/kni/kni_fifo.h:30:
+        int success = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#202: FILE: kernel/linux/kni/kni_fifo.h:31:
+        unsigned i;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: kernel/linux/kni/kni_fifo.h:31:
+        unsigned i;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#202: FILE: kernel/linux/kni/kni_fifo.h:31:
+        unsigned i;

ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: kernel/linux/kni/kni_fifo.h:32:
+        const unsigned mask = (fifo->len) - 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: kernel/linux/kni/kni_fifo.h:32:
+        const unsigned mask = (fifo->len) - 1;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#203: FILE: kernel/linux/kni/kni_fifo.h:32:
+        const unsigned mask = (fifo->len) - 1;

ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: kernel/linux/kni/kni_fifo.h:33:
+        unsigned idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: kernel/linux/kni/kni_fifo.h:33:
+        unsigned idx;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#204: FILE: kernel/linux/kni/kni_fifo.h:33:
+        unsigned idx;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#206: FILE: kernel/linux/kni/kni_fifo.h:35:
+        if (unlikely(n == 0)) $

ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: kernel/linux/kni/kni_fifo.h:35:
+        if (unlikely(n == 0)) $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: kernel/linux/kni/kni_fifo.h:35:
+        if (unlikely(n == 0)) $

ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: kernel/linux/kni/kni_fifo.h:36:
+                return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: kernel/linux/kni/kni_fifo.h:36:
+                return 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: kernel/linux/kni/kni_fifo.h:38:
+        /* Move fifo->write.head atomically. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#210: FILE: kernel/linux/kni/kni_fifo.h:39:
+        do {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: kernel/linux/kni/kni_fifo.h:39:
+        do {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#211: FILE: kernel/linux/kni/kni_fifo.h:40:
+                /* Reset n to the initial burst count. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#212: FILE: kernel/linux/kni/kni_fifo.h:41:
+                n = max;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#212: FILE: kernel/linux/kni/kni_fifo.h:41:
+                n = max;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: kernel/linux/kni/kni_fifo.h:43:
+                fifo_write = fifo->write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#216: FILE: kernel/linux/kni/kni_fifo.h:43:
+                fifo_write = fifo->write;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#217: FILE: kernel/linux/kni/kni_fifo.h:44:
+                fifo_read = fifo->read;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: kernel/linux/kni/kni_fifo.h:44:
+                fifo_read = fifo->read;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#225: FILE: kernel/linux/kni/kni_fifo.h:46:
+                /* The subtraction is done between two unsigned 32bits value$

ERROR:CODE_INDENT: code indent should use tabs where possible
#226: FILE: kernel/linux/kni/kni_fifo.h:47:
+                 * (the result is always modulo 32 bits even if we have$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: kernel/linux/kni/kni_fifo.h:48:
+                 * fifo_write > fifo_read). So 'free_entries' is always$

ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: kernel/linux/kni/kni_fifo.h:49:
+                 * between 0 and fifo->len-1. */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#228: FILE: kernel/linux/kni/kni_fifo.h:49:
+                 * between 0 and fifo->len-1. */

ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: kernel/linux/kni/kni_fifo.h:50:
+                free_entries = mask + fifo_read - fifo_write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: kernel/linux/kni/kni_fifo.h:50:
+                free_entries = mask + fifo_read - fifo_write;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#232: FILE: kernel/linux/kni/kni_fifo.h:52:
+                /* Check that we have enough room in fifo. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#233: FILE: kernel/linux/kni/kni_fifo.h:53:
+                if (unlikely(n > free_entries)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: kernel/linux/kni/kni_fifo.h:53:
+                if (unlikely(n > free_entries)) {$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#234: FILE: kernel/linux/kni/kni_fifo.h:54:
+                        if (unlikely(free_entries == 0)) $

ERROR:CODE_INDENT: code indent should use tabs where possible
#234: FILE: kernel/linux/kni/kni_fifo.h:54:
+                        if (unlikely(free_entries == 0)) $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: kernel/linux/kni/kni_fifo.h:54:
+                        if (unlikely(free_entries == 0)) $

ERROR:CODE_INDENT: code indent should use tabs where possible
#235: FILE: kernel/linux/kni/kni_fifo.h:55:
+                                return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: kernel/linux/kni/kni_fifo.h:55:
+                                return 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#236: FILE: kernel/linux/kni/kni_fifo.h:56:
+                        n = free_entries;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: kernel/linux/kni/kni_fifo.h:56:
+                        n = free_entries;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#237: FILE: kernel/linux/kni/kni_fifo.h:57:
+                }   $

ERROR:CODE_INDENT: code indent should use tabs where possible
#237: FILE: kernel/linux/kni/kni_fifo.h:57:
+                }   $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#237: FILE: kernel/linux/kni/kni_fifo.h:57:
+                }   $

ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: kernel/linux/kni/kni_fifo.h:59:
+                new_write = fifo_write + n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: kernel/linux/kni/kni_fifo.h:59:
+                new_write = fifo_write + n;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: kernel/linux/kni/kni_fifo.h:60:
+                if (cmpxchg(&fifo->write, fifo_write, new_write) == fifo_write)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: kernel/linux/kni/kni_fifo.h:60:
+                if (cmpxchg(&fifo->write, fifo_write, new_write) == fifo_write)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: kernel/linux/kni/kni_fifo.h:61:
+                        success = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: kernel/linux/kni/kni_fifo.h:61:
+                        success = 1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#243: FILE: kernel/linux/kni/kni_fifo.h:63:
+        } while (unlikely(success == 0));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: kernel/linux/kni/kni_fifo.h:63:
+        } while (unlikely(success == 0));$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#244: FILE: kernel/linux/kni/kni_fifo.h:64:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#244: FILE: kernel/linux/kni/kni_fifo.h:64:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: kernel/linux/kni/kni_fifo.h:64:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#245: FILE: kernel/linux/kni/kni_fifo.h:65:
+        /* Write entries in fifo. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#246: FILE: kernel/linux/kni/kni_fifo.h:66:
+        idx = fifo_write & mask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: kernel/linux/kni/kni_fifo.h:66:
+        idx = fifo_write & mask;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: kernel/linux/kni/kni_fifo.h:67:
+        if (likely(idx + n < fifo->len)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: kernel/linux/kni/kni_fifo.h:67:
+        if (likely(idx + n < fifo->len)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#248: FILE: kernel/linux/kni/kni_fifo.h:68:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: kernel/linux/kni/kni_fifo.h:68:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#248: FILE: kernel/linux/kni/kni_fifo.h:68:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: kernel/linux/kni/kni_fifo.h:69:
+                        fifo->buffer[idx] = data[i];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: kernel/linux/kni/kni_fifo.h:69:
+                        fifo->buffer[idx] = data[i];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#250: FILE: kernel/linux/kni/kni_fifo.h:70:
+                        fifo->buffer[idx + 1] = data[i + 1];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: kernel/linux/kni/kni_fifo.h:70:
+                        fifo->buffer[idx + 1] = data[i + 1];$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#251: FILE: kernel/linux/kni/kni_fifo.h:71:
+                        fifo->buffer[idx + 2] = data[i + 2]; $

ERROR:CODE_INDENT: code indent should use tabs where possible
#251: FILE: kernel/linux/kni/kni_fifo.h:71:
+                        fifo->buffer[idx + 2] = data[i + 2]; $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: kernel/linux/kni/kni_fifo.h:71:
+                        fifo->buffer[idx + 2] = data[i + 2]; $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#252: FILE: kernel/linux/kni/kni_fifo.h:72:
+                        fifo->buffer[idx + 3] = data[i + 3]; $

ERROR:CODE_INDENT: code indent should use tabs where possible
#252: FILE: kernel/linux/kni/kni_fifo.h:72:
+                        fifo->buffer[idx + 3] = data[i + 3]; $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#252: FILE: kernel/linux/kni/kni_fifo.h:72:
+                        fifo->buffer[idx + 3] = data[i + 3]; $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#253: FILE: kernel/linux/kni/kni_fifo.h:73:
+                }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#253: FILE: kernel/linux/kni/kni_fifo.h:73:
+                }       $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#253: FILE: kernel/linux/kni/kni_fifo.h:73:
+                }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#254: FILE: kernel/linux/kni/kni_fifo.h:74:
+                switch (n & 0x3) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#254: FILE: kernel/linux/kni/kni_fifo.h:74:
+                switch (n & 0x3) {$

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#254: FILE: kernel/linux/kni/kni_fifo.h:74:
+                switch (n & 0x3) {
+                        case 3: fifo->buffer[idx++] = data[i++];
+                        case 2: fifo->buffer[idx++] = data[i++];
+                        case 1: fifo->buffer[idx++] = data[i++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#255: FILE: kernel/linux/kni/kni_fifo.h:75:
+                        case 3: fifo->buffer[idx++] = data[i++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#255: FILE: kernel/linux/kni/kni_fifo.h:75:
+                        case 3: fifo->buffer[idx++] = data[i++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#255: FILE: kernel/linux/kni/kni_fifo.h:75:
+                        case 3: fifo->buffer[idx++] = data[i++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#256: FILE: kernel/linux/kni/kni_fifo.h:76:
+                        case 2: fifo->buffer[idx++] = data[i++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#256: FILE: kernel/linux/kni/kni_fifo.h:76:
+                        case 2: fifo->buffer[idx++] = data[i++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#256: FILE: kernel/linux/kni/kni_fifo.h:76:
+                        case 2: fifo->buffer[idx++] = data[i++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#257: FILE: kernel/linux/kni/kni_fifo.h:77:
+                        case 1: fifo->buffer[idx++] = data[i++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: kernel/linux/kni/kni_fifo.h:77:
+                        case 1: fifo->buffer[idx++] = data[i++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#257: FILE: kernel/linux/kni/kni_fifo.h:77:
+                        case 1: fifo->buffer[idx++] = data[i++];

ERROR:TRAILING_WHITESPACE: trailing whitespace
#258: FILE: kernel/linux/kni/kni_fifo.h:78:
+                }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#258: FILE: kernel/linux/kni/kni_fifo.h:78:
+                }       $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#258: FILE: kernel/linux/kni/kni_fifo.h:78:
+                }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: kernel/linux/kni/kni_fifo.h:79:
+        } else {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: kernel/linux/kni/kni_fifo.h:79:
+        } else {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#260: FILE: kernel/linux/kni/kni_fifo.h:80:
+                for (i = 0; i < n; i++) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: kernel/linux/kni/kni_fifo.h:80:
+                for (i = 0; i < n; i++) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#260: FILE: kernel/linux/kni/kni_fifo.h:80:
+                for (i = 0; i < n; i++) {
+                        fifo->buffer[(fifo_write + i) & mask] = data[i];
+                }       

ERROR:CODE_INDENT: code indent should use tabs where possible
#261: FILE: kernel/linux/kni/kni_fifo.h:81:
+                        fifo->buffer[(fifo_write + i) & mask] = data[i];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: kernel/linux/kni/kni_fifo.h:81:
+                        fifo->buffer[(fifo_write + i) & mask] = data[i];$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#262: FILE: kernel/linux/kni/kni_fifo.h:82:
+                }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#262: FILE: kernel/linux/kni/kni_fifo.h:82:
+                }       $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: kernel/linux/kni/kni_fifo.h:82:
+                }       $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#263: FILE: kernel/linux/kni/kni_fifo.h:83:
+        }       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: kernel/linux/kni/kni_fifo.h:83:
+        }       $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: kernel/linux/kni/kni_fifo.h:83:
+        }       $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#264: FILE: kernel/linux/kni/kni_fifo.h:84:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#264: FILE: kernel/linux/kni/kni_fifo.h:84:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#264: FILE: kernel/linux/kni/kni_fifo.h:84:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#265: FILE: kernel/linux/kni/kni_fifo.h:85:
+        mb();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: kernel/linux/kni/kni_fifo.h:85:
+        mb();$

WARNING:MEMORY_BARRIER: memory barrier without comment
#265: FILE: kernel/linux/kni/kni_fifo.h:85:
+        mb();

ERROR:TRAILING_WHITESPACE: trailing whitespace
#266: FILE: kernel/linux/kni/kni_fifo.h:86:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#266: FILE: kernel/linux/kni/kni_fifo.h:86:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#266: FILE: kernel/linux/kni/kni_fifo.h:86:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#267: FILE: kernel/linux/kni/kni_fifo.h:87:
+        /* If there are other enqueues in progress that preceded us,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#268: FILE: kernel/linux/kni/kni_fifo.h:88:
+         * we need to wait for them to complete.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#269: FILE: kernel/linux/kni/kni_fifo.h:89:
+         */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: kernel/linux/kni/kni_fifo.h:90:
+        while (unlikely(fifo->write != fifo_write))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: kernel/linux/kni/kni_fifo.h:90:
+        while (unlikely(fifo->write != fifo_write))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#271: FILE: kernel/linux/kni/kni_fifo.h:91:
+                cpu_relax();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: kernel/linux/kni/kni_fifo.h:91:
+                cpu_relax();$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#272: FILE: kernel/linux/kni/kni_fifo.h:92:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#272: FILE: kernel/linux/kni/kni_fifo.h:92:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: kernel/linux/kni/kni_fifo.h:92:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#273: FILE: kernel/linux/kni/kni_fifo.h:93:
+        fifo->write = new_write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: kernel/linux/kni/kni_fifo.h:93:
+        fifo->write = new_write;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: kernel/linux/kni/kni_fifo.h:94:
+        return n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#274: FILE: kernel/linux/kni/kni_fifo.h:94:
+        return n;$

WARNING:TYPO_SPELLING: 'actully' may be misspelled - perhaps 'actually'?
#295: FILE: kernel/linux/kni/kni_fifo.h:107:
+ * Get up to num elements from the fifo. Return the number actully read.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#300: FILE: kernel/linux/kni/kni_fifo.h:112:
+kni_mc_fifo_get(struct rte_kni_fifo *fifo, void **data, unsigned n)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#301: FILE: kernel/linux/kni/kni_fifo.h:113:
+{       $

ERROR:CODE_INDENT: code indent should use tabs where possible
#302: FILE: kernel/linux/kni/kni_fifo.h:114:
+        unsigned fifo_read, fifo_write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: kernel/linux/kni/kni_fifo.h:114:
+        unsigned fifo_read, fifo_write;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#302: FILE: kernel/linux/kni/kni_fifo.h:114:
+        unsigned fifo_read, fifo_write;

ERROR:CODE_INDENT: code indent should use tabs where possible
#303: FILE: kernel/linux/kni/kni_fifo.h:115:
+        unsigned new_read, entries;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: kernel/linux/kni/kni_fifo.h:115:
+        unsigned new_read, entries;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#303: FILE: kernel/linux/kni/kni_fifo.h:115:
+        unsigned new_read, entries;

ERROR:CODE_INDENT: code indent should use tabs where possible
#304: FILE: kernel/linux/kni/kni_fifo.h:116:
+        const unsigned max = n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: kernel/linux/kni/kni_fifo.h:116:
+        const unsigned max = n;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#304: FILE: kernel/linux/kni/kni_fifo.h:116:
+        const unsigned max = n;

ERROR:CODE_INDENT: code indent should use tabs where possible
#305: FILE: kernel/linux/kni/kni_fifo.h:117:
+        int success = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#305: FILE: kernel/linux/kni/kni_fifo.h:117:
+        int success = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#306: FILE: kernel/linux/kni/kni_fifo.h:118:
+        unsigned i;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: kernel/linux/kni/kni_fifo.h:118:
+        unsigned i;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#306: FILE: kernel/linux/kni/kni_fifo.h:118:
+        unsigned i;

ERROR:CODE_INDENT: code indent should use tabs where possible
#307: FILE: kernel/linux/kni/kni_fifo.h:119:
+        unsigned mask = (fifo->len) - 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#307: FILE: kernel/linux/kni/kni_fifo.h:119:
+        unsigned mask = (fifo->len) - 1;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#307: FILE: kernel/linux/kni/kni_fifo.h:119:
+        unsigned mask = (fifo->len) - 1;

ERROR:CODE_INDENT: code indent should use tabs where possible
#308: FILE: kernel/linux/kni/kni_fifo.h:120:
+        unsigned idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#308: FILE: kernel/linux/kni/kni_fifo.h:120:
+        unsigned idx;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#308: FILE: kernel/linux/kni/kni_fifo.h:120:
+        unsigned idx;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#309: FILE: kernel/linux/kni/kni_fifo.h:121:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#309: FILE: kernel/linux/kni/kni_fifo.h:121:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: kernel/linux/kni/kni_fifo.h:121:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#310: FILE: kernel/linux/kni/kni_fifo.h:122:
+        if (unlikely(n == 0))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: kernel/linux/kni/kni_fifo.h:122:
+        if (unlikely(n == 0))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#311: FILE: kernel/linux/kni/kni_fifo.h:123:
+                return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#311: FILE: kernel/linux/kni/kni_fifo.h:123:
+                return 0;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#312: FILE: kernel/linux/kni/kni_fifo.h:124:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: kernel/linux/kni/kni_fifo.h:124:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: kernel/linux/kni/kni_fifo.h:124:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#313: FILE: kernel/linux/kni/kni_fifo.h:125:
+        /* Move fifo->read.head atomically. */$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#314: FILE: kernel/linux/kni/kni_fifo.h:126:
+        do {    $

ERROR:CODE_INDENT: code indent should use tabs where possible
#314: FILE: kernel/linux/kni/kni_fifo.h:126:
+        do {    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#314: FILE: kernel/linux/kni/kni_fifo.h:126:
+        do {    $

ERROR:CODE_INDENT: code indent should use tabs where possible
#315: FILE: kernel/linux/kni/kni_fifo.h:127:
+                /* Restore n as it may change every loop. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#316: FILE: kernel/linux/kni/kni_fifo.h:128:
+                n = max;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#316: FILE: kernel/linux/kni/kni_fifo.h:128:
+                n = max;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#317: FILE: kernel/linux/kni/kni_fifo.h:129:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#317: FILE: kernel/linux/kni/kni_fifo.h:129:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: kernel/linux/kni/kni_fifo.h:129:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#318: FILE: kernel/linux/kni/kni_fifo.h:130:
+                fifo_read = fifo->read;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: kernel/linux/kni/kni_fifo.h:130:
+                fifo_read = fifo->read;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#319: FILE: kernel/linux/kni/kni_fifo.h:131:
+                fifo_write = fifo->write;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#319: FILE: kernel/linux/kni/kni_fifo.h:131:
+                fifo_write = fifo->write;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#320: FILE: kernel/linux/kni/kni_fifo.h:132:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#320: FILE: kernel/linux/kni/kni_fifo.h:132:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: kernel/linux/kni/kni_fifo.h:132:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: kernel/linux/kni/kni_fifo.h:133:
+                /* The subtraction is done between two unsigned 32bits value$

ERROR:CODE_INDENT: code indent should use tabs where possible
#322: FILE: kernel/linux/kni/kni_fifo.h:134:
+                 * (the result is always modulo 32 bits even if we have$

ERROR:CODE_INDENT: code indent should use tabs where possible
#323: FILE: kernel/linux/kni/kni_fifo.h:135:
+                 * fifo_read > fifo_write). So 'entries' is always between 0$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#324: FILE: kernel/linux/kni/kni_fifo.h:136:
+                 * and fifo->len-1. */ $

ERROR:CODE_INDENT: code indent should use tabs where possible
#324: FILE: kernel/linux/kni/kni_fifo.h:136:
+                 * and fifo->len-1. */ $

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#324: FILE: kernel/linux/kni/kni_fifo.h:136:
+                 * and fifo->len-1. */ 

ERROR:CODE_INDENT: code indent should use tabs where possible
#325: FILE: kernel/linux/kni/kni_fifo.h:137:
+                entries = fifo_write - fifo_read;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: kernel/linux/kni/kni_fifo.h:137:
+                entries = fifo_write - fifo_read;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#326: FILE: kernel/linux/kni/kni_fifo.h:138:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: kernel/linux/kni/kni_fifo.h:138:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: kernel/linux/kni/kni_fifo.h:138:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: kernel/linux/kni/kni_fifo.h:139:
+                /* Set the actual entries for dequeue. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: kernel/linux/kni/kni_fifo.h:140:
+                if (n > entries) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: kernel/linux/kni/kni_fifo.h:140:
+                if (n > entries) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: kernel/linux/kni/kni_fifo.h:141:
+                        if (unlikely(entries == 0))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: kernel/linux/kni/kni_fifo.h:141:
+                        if (unlikely(entries == 0))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: kernel/linux/kni/kni_fifo.h:142:
+                                return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: kernel/linux/kni/kni_fifo.h:142:
+                                return 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: kernel/linux/kni/kni_fifo.h:143:
+                        n = entries;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: kernel/linux/kni/kni_fifo.h:143:
+                        n = entries;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#332: FILE: kernel/linux/kni/kni_fifo.h:144:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: kernel/linux/kni/kni_fifo.h:144:
+                }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#333: FILE: kernel/linux/kni/kni_fifo.h:145:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: kernel/linux/kni/kni_fifo.h:145:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: kernel/linux/kni/kni_fifo.h:145:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#334: FILE: kernel/linux/kni/kni_fifo.h:146:
+                new_read = fifo_read + n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: kernel/linux/kni/kni_fifo.h:146:
+                new_read = fifo_read + n;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#335: FILE: kernel/linux/kni/kni_fifo.h:147:
+                if (cmpxchg(&fifo->read, fifo_read, new_read) == fifo_read)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#335: FILE: kernel/linux/kni/kni_fifo.h:147:
+                if (cmpxchg(&fifo->read, fifo_read, new_read) == fifo_read)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#336: FILE: kernel/linux/kni/kni_fifo.h:148:
+                        success = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: kernel/linux/kni/kni_fifo.h:148:
+                        success = 1;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#337: FILE: kernel/linux/kni/kni_fifo.h:149:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#337: FILE: kernel/linux/kni/kni_fifo.h:149:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: kernel/linux/kni/kni_fifo.h:149:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: kernel/linux/kni/kni_fifo.h:150:
+        } while (unlikely(success == 0));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#338: FILE: kernel/linux/kni/kni_fifo.h:150:
+        } while (unlikely(success == 0));$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#339: FILE: kernel/linux/kni/kni_fifo.h:151:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#339: FILE: kernel/linux/kni/kni_fifo.h:151:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#339: FILE: kernel/linux/kni/kni_fifo.h:151:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#340: FILE: kernel/linux/kni/kni_fifo.h:152:
+        /* Copy entries from fifo. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#341: FILE: kernel/linux/kni/kni_fifo.h:153:
+        idx = fifo_read & mask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#341: FILE: kernel/linux/kni/kni_fifo.h:153:
+        idx = fifo_read & mask;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#342: FILE: kernel/linux/kni/kni_fifo.h:154:
+        if (likely(idx + n < fifo->len)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#342: FILE: kernel/linux/kni/kni_fifo.h:154:
+        if (likely(idx + n < fifo->len)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#343: FILE: kernel/linux/kni/kni_fifo.h:155:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: kernel/linux/kni/kni_fifo.h:155:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#343: FILE: kernel/linux/kni/kni_fifo.h:155:
+                for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: kernel/linux/kni/kni_fifo.h:156:
+                        data[i] = fifo->buffer[idx];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: kernel/linux/kni/kni_fifo.h:156:
+                        data[i] = fifo->buffer[idx];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#345: FILE: kernel/linux/kni/kni_fifo.h:157:
+                        data[i + 1] = fifo->buffer[idx + 1];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: kernel/linux/kni/kni_fifo.h:157:
+                        data[i + 1] = fifo->buffer[idx + 1];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#346: FILE: kernel/linux/kni/kni_fifo.h:158:
+                        data[i + 2] = fifo->buffer[idx + 2];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: kernel/linux/kni/kni_fifo.h:158:
+                        data[i + 2] = fifo->buffer[idx + 2];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#347: FILE: kernel/linux/kni/kni_fifo.h:159:
+                        data[i + 3] = fifo->buffer[idx + 3];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#347: FILE: kernel/linux/kni/kni_fifo.h:159:
+                        data[i + 3] = fifo->buffer[idx + 3];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#348: FILE: kernel/linux/kni/kni_fifo.h:160:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#348: FILE: kernel/linux/kni/kni_fifo.h:160:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#349: FILE: kernel/linux/kni/kni_fifo.h:161:
+                switch (n & 0x3) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#349: FILE: kernel/linux/kni/kni_fifo.h:161:
+                switch (n & 0x3) {$

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#349: FILE: kernel/linux/kni/kni_fifo.h:161:
+                switch (n & 0x3) {
+                        case 3: data[i++] = fifo->buffer[idx++];
+                        case 2: data[i++] = fifo->buffer[idx++];
+                        case 1: data[i++] = fifo->buffer[idx++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#350: FILE: kernel/linux/kni/kni_fifo.h:162:
+                        case 3: data[i++] = fifo->buffer[idx++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#350: FILE: kernel/linux/kni/kni_fifo.h:162:
+                        case 3: data[i++] = fifo->buffer[idx++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#350: FILE: kernel/linux/kni/kni_fifo.h:162:
+                        case 3: data[i++] = fifo->buffer[idx++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#351: FILE: kernel/linux/kni/kni_fifo.h:163:
+                        case 2: data[i++] = fifo->buffer[idx++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#351: FILE: kernel/linux/kni/kni_fifo.h:163:
+                        case 2: data[i++] = fifo->buffer[idx++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#351: FILE: kernel/linux/kni/kni_fifo.h:163:
+                        case 2: data[i++] = fifo->buffer[idx++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#352: FILE: kernel/linux/kni/kni_fifo.h:164:
+                        case 1: data[i++] = fifo->buffer[idx++];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#352: FILE: kernel/linux/kni/kni_fifo.h:164:
+                        case 1: data[i++] = fifo->buffer[idx++];$

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#352: FILE: kernel/linux/kni/kni_fifo.h:164:
+                        case 1: data[i++] = fifo->buffer[idx++];

ERROR:CODE_INDENT: code indent should use tabs where possible
#353: FILE: kernel/linux/kni/kni_fifo.h:165:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#353: FILE: kernel/linux/kni/kni_fifo.h:165:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#354: FILE: kernel/linux/kni/kni_fifo.h:166:
+        } else {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: kernel/linux/kni/kni_fifo.h:166:
+        } else {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#355: FILE: kernel/linux/kni/kni_fifo.h:167:
+                for (i = 0; i < n; i++) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#355: FILE: kernel/linux/kni/kni_fifo.h:167:
+                for (i = 0; i < n; i++) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#355: FILE: kernel/linux/kni/kni_fifo.h:167:
+                for (i = 0; i < n; i++) {
+                        data[i] = fifo->buffer[(fifo_read + i) & mask];
+                }

ERROR:CODE_INDENT: code indent should use tabs where possible
#356: FILE: kernel/linux/kni/kni_fifo.h:168:
+                        data[i] = fifo->buffer[(fifo_read + i) & mask];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#356: FILE: kernel/linux/kni/kni_fifo.h:168:
+                        data[i] = fifo->buffer[(fifo_read + i) & mask];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#357: FILE: kernel/linux/kni/kni_fifo.h:169:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#357: FILE: kernel/linux/kni/kni_fifo.h:169:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#358: FILE: kernel/linux/kni/kni_fifo.h:170:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: kernel/linux/kni/kni_fifo.h:170:
+        }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#359: FILE: kernel/linux/kni/kni_fifo.h:171:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#359: FILE: kernel/linux/kni/kni_fifo.h:171:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#359: FILE: kernel/linux/kni/kni_fifo.h:171:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#360: FILE: kernel/linux/kni/kni_fifo.h:172:
+        mb();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: kernel/linux/kni/kni_fifo.h:172:
+        mb();$

WARNING:MEMORY_BARRIER: memory barrier without comment
#360: FILE: kernel/linux/kni/kni_fifo.h:172:
+        mb();

ERROR:TRAILING_WHITESPACE: trailing whitespace
#361: FILE: kernel/linux/kni/kni_fifo.h:173:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#361: FILE: kernel/linux/kni/kni_fifo.h:173:
+        $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: kernel/linux/kni/kni_fifo.h:173:
+        $

ERROR:CODE_INDENT: code indent should use tabs where possible
#362: FILE: kernel/linux/kni/kni_fifo.h:174:
+        /*$

ERROR:CODE_INDENT: code indent should use tabs where possible
#363: FILE: kernel/linux/kni/kni_fifo.h:175:
+         * If there are other dequeues in progress that preceded us,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#364: FILE: kernel/linux/kni/kni_fifo.h:176:
+         * we need to wait for them to complete.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: kernel/linux/kni/kni_fifo.h:177:
+         */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#366: FILE: kernel/linux/kni/kni_fifo.h:178:
+        while (unlikely(fifo->read != fifo_read))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#366: FILE: kernel/linux/kni/kni_fifo.h:178:
+        while (unlikely(fifo->read != fifo_read))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#367: FILE: kernel/linux/kni/kni_fifo.h:179:
+                cpu_relax();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#367: FILE: kernel/linux/kni/kni_fifo.h:179:
+                cpu_relax();$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#368: FILE: kernel/linux/kni/kni_fifo.h:180:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#368: FILE: kernel/linux/kni/kni_fifo.h:180:
+                $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#368: FILE: kernel/linux/kni/kni_fifo.h:180:
+                $

ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: kernel/linux/kni/kni_fifo.h:181:
+        fifo->read = new_read;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: kernel/linux/kni/kni_fifo.h:181:
+        fifo->read = new_read;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#370: FILE: kernel/linux/kni/kni_fifo.h:182:
+        return n;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#370: FILE: kernel/linux/kni/kni_fifo.h:182:
+        return n;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#371: FILE: kernel/linux/kni/kni_fifo.h:183:
+}       $

WARNING:TYPO_SPELLING: 'actully' may be misspelled - perhaps 'actually'?
#380: FILE: kernel/linux/kni/kni_fifo.h:187:
+ * Get up to num elements from the fifo. Return the number actully read

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#398: FILE: kernel/linux/kni/kni_misc.c:295:
+	unsigned i, tx_queues_num;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kni_ioctl_create', this function's name, in a string
#410: FILE: kernel/linux/kni/kni_misc.c:307:
+		pr_err("allocate memory in kni_ioctl_create");

WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#410: FILE: kernel/linux/kni/kni_misc.c:307:
+	if (!dev_info) {
+		pr_err("allocate memory in kni_ioctl_create");

ERROR:TRAILING_WHITESPACE: trailing whitespace
#560: FILE: kernel/linux/kni/kni_misc.c:408:
+^I$

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kni_ioctl_release', this function's name, in a string
#658: FILE: kernel/linux/kni/kni_misc.c:489:
+		pr_err("allocate memory in kni_ioctl_release");

WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#658: FILE: kernel/linux/kni/kni_misc.c:489:
+	if (!dev_info) {
+		pr_err("allocate memory in kni_ioctl_release");

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#723: FILE: kernel/linux/kni/kni_net.c:244:
+	unsigned i;

ERROR:SPACING: spaces required around that '<' (ctx:VxW)
#725: FILE: kernel/linux/kni/kni_net.c:246:
+	for (i = 0; i< kni->fifos_num; i++) {
 	             ^

ERROR:SPACING: spaces required around that '<' (ctx:VxW)
#730: FILE: kernel/linux/kni/kni_net.c:251:
+	for (i = 0; i< kni->fifos_num; i++) {
 	             ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#747: FILE: kernel/linux/kni/kni_net.c:277:
+	unsigned fifo_idx, fifos_num = kni->fifos_num;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#749: FILE: kernel/linux/kni/kni_net.c:279:
+	if (unlikely(fifos_num == 1)) {
+		return 0;
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#767: FILE: kernel/linux/kni/kni_net.c:301:
+	unsigned fifo_idx;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#954: FILE: kernel/linux/kni/kni_net.c:650:
+	for (i = 0; i < kni->fifos_num; i++) {
+		(*kni_net_rx_func)(kni, i);
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1007: FILE: lib/librte_kni/rte_kni.c:85:
+	unsigned queues_num;		    /**< Num of tx queues of KNI vnic */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1008: FILE: lib/librte_kni/rte_kni.c:86:
+	unsigned fifos_num;                 /**< TX/RX/Alloc/Free fifos number */

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1009: FILE: lib/librte_kni/rte_kni.c:87:
+^I$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1019: FILE: lib/librte_kni/rte_kni.c:95:
+static void kni_free_mbufs(struct rte_kni *kni, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1020: FILE: lib/librte_kni/rte_kni.c:96:
+static void kni_allocate_mbufs(struct rte_kni *kni, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1029: FILE: lib/librte_kni/rte_kni.c:146:
+kni_reserve_mz(struct rte_kni *kni, unsigned fifos_num)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1031: FILE: lib/librte_kni/rte_kni.c:148:
+	unsigned i, j;

WARNING:TABSTOP: Statements should start on a tabstop
#1071: FILE: lib/librte_kni/rte_kni.c:172:
+	 for (i = 0; i < fifos_num; i++) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1126: FILE: lib/librte_kni/rte_kni.c:238:
+kni_release_mz(struct rte_kni *kni, unsigned fifos_num)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1132: FILE: lib/librte_kni/rte_kni.c:240:
+	for (unsigned i = 0; i < fifos_num; i++) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1145: FILE: lib/librte_kni/rte_kni.c:257:
+	unsigned i, fifos_num;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1216: FILE: lib/librte_kni/rte_kni.c:382:
+	for (i = 0; i < fifos_num; i++) {
+		kni_allocate_mbufs(kni, i);
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1233: FILE: lib/librte_kni/rte_kni.c:465:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1276: FILE: lib/librte_kni/rte_kni.c:668:
+		unsigned int num, unsigned index)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1300: FILE: lib/librte_kni/rte_kni.c:688:
+		unsigned int num, unsigned index)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1315: FILE: lib/librte_kni/rte_kni.c:700:
+kni_free_mbufs(struct rte_kni *kni, unsigned index)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1330: FILE: lib/librte_kni/rte_kni.c:713:
+kni_allocate_mbufs(struct rte_kni *kni, unsigned index)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1361: FILE: lib/librte_kni/rte_kni.h:79:
+^Iunsigned fifos_num; $

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1361: FILE: lib/librte_kni/rte_kni.h:79:
+	unsigned fifos_num; 

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1362: FILE: lib/librte_kni/rte_kni.h:80:
+	unsigned queues_num;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1378: FILE: lib/librte_kni/rte_kni.h:175:
+		unsigned num, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1378: FILE: lib/librte_kni/rte_kni.h:175:
+		unsigned num, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1394: FILE: lib/librte_kni/rte_kni.h:196:
+		unsigned num, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1394: FILE: lib/librte_kni/rte_kni.h:196:
+		unsigned num, unsigned index);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1421: FILE: lib/librte_kni/rte_kni_common.h:130:
+	unsigned fifos_num;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1422: FILE: lib/librte_kni/rte_kni_common.h:131:
+	unsigned queues_num;

total: 171 errors, 167 warnings, 1309 lines checked
Warning in lib/librte_kni/rte_kni.c:
Declaring a variable inside for()
Previous message (by thread): [dpdk-test-report] |SUCCESS| pw84817 [PATCH] net/e1000: fix incorrect return value if filter type not supported.
Next message (by thread): [dpdk-test-report] |SUCCESS| pw84786 net/e1000: fix incorrect return value if filter type not supported.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list