[dpdk-test-report] |WARNING| pw65435 [RFC PATCH 3/5] test: add graph functional tests

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jan 31 18:04:54 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65435

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#159: FILE: app/test/test_graph.c:23:
+uint16_t

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#163: FILE: app/test/test_graph.c:27:
+uint16_t

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#167: FILE: app/test/test_graph.c:31:
+uint16_t

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#171: FILE: app/test/test_graph.c:35:
+uint16_t

ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: app/test/test_graph.c:65:
+        char name[NODE_NAMESIZE];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: app/test/test_graph.c:65:
+        char name[NODE_NAMESIZE];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: app/test/test_graph.c:67:
+        uint16_t nb_edges;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: app/test/test_graph.c:67:
+        uint16_t nb_edges;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: app/test/test_graph.c:68:
+        const char *next_nodes[MAX_NODES];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: app/test/test_graph.c:68:
+        const char *next_nodes[MAX_NODES];$

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#258: FILE: app/test/test_graph.c:122:
+	*(uint32_t*)node->ctx = node->id;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#269: FILE: app/test/test_graph.c:133:
+	.next_nodes = {"test_node00","test_node00-test_node11"},
 	                            ^

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#329: FILE: app/test/test_graph.c:193:
+	if (*(uint32_t*)node->ctx == test_node0.id) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#340: FILE: app/test/test_graph.c:204:
+			data = (struct rte_mbuf*)objs[i];

ERROR:SPACING: space required after that ',' (ctx:VxV)
#343: FILE: app/test/test_graph.c:207:
+				      " = %u got = %u
",tm->test_node[0].idx,
 				                        ^

WARNING:TYPO_SPELLING: 'missmatch' may be misspelled - perhaps 'mismatch'?
#361: FILE: app/test/test_graph.c:225:
+			printf("Count missmatch at node 0
");

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#375: FILE: app/test/test_graph.c:239:
+		rte_node_enqueue(graph, node, 0, (void**)&mbuf_p[1][0],

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#389: FILE: app/test/test_graph.c:253:
+				 (void**)&mbuf_p[1][obj_node0], obj_node1);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#391: FILE: app/test/test_graph.c:255:
+	} else if (*(uint32_t*)node->ctx == tm->test_node[1].idx)

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#393: FILE: app/test/test_graph.c:257:
+	else if (*(uint32_t*)node->ctx == tm->test_node[2].idx)

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#395: FILE: app/test/test_graph.c:259:
+	else if (*(uint32_t*)node->ctx == tm->test_node[3].idx)

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#417: FILE: app/test/test_graph.c:281:
+		data = (struct rte_mbuf*)objs[i];

ERROR:SPACING: space required after that ',' (ctx:VxV)
#420: FILE: app/test/test_graph.c:284:
+			       " got = %u
",tm->test_node[1].idx,
 			                    ^

WARNING:TYPO_SPELLING: 'missmatch' may be misspelled - perhaps 'mismatch'?
#437: FILE: app/test/test_graph.c:301:
+		printf("Count missmatch at node 1
");

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#451: FILE: app/test/test_graph.c:315:
+			 (void**)&mbuf_p[2][0], obj_node0);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#470: FILE: app/test/test_graph.c:334:
+		data = (struct rte_mbuf*)objs[i];

ERROR:SPACING: space required after that ',' (ctx:VxV)
#473: FILE: app/test/test_graph.c:337:
+			       " got = %u
",tm->test_node[2].idx,
 			                    ^

WARNING:TYPO_SPELLING: 'missmatch' may be misspelled - perhaps 'mismatch'?
#490: FILE: app/test/test_graph.c:354:
+		printf("Count missmatch at node 2
");

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#503: FILE: app/test/test_graph.c:367:
+		rte_node_enqueue(graph, node, 0, (void**)&mbuf_p[3][0],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#524: FILE: app/test/test_graph.c:388:
+		data = (struct rte_mbuf*)objs[i];

ERROR:SPACING: space required after that ',' (ctx:VxV)
#527: FILE: app/test/test_graph.c:391:
+			       " got = %u
",tm->test_node[3].idx,
 			                    ^

WARNING:TYPO_SPELLING: 'missmatch' may be misspelled - perhaps 'mismatch'?
#544: FILE: app/test/test_graph.c:408:
+		printf("Count missmatch at node 3
");

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#561: FILE: app/test/test_graph.c:425:
+		rte_node_enqueue(graph, node, 0, (void**)&mbuf_p[4][0],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#616: FILE: app/test/test_graph.c:480:
+		if (count != tm->test_node[i].node.nb_edges * sizeof(char*)) {

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#672: FILE: app/test/test_graph.c:536:
+			printf("Got invalid node id 
");

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#733: FILE: app/test/test_graph.c:597:
+	const char *node_patterns_dummy[] = {

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#753: FILE: app/test/test_graph.c:617:
+		printf("Got invalid node id 
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#782: FILE: app/test/test_graph.c:646:
+	for (i = 0; i < 5; i++) {
+		rte_graph_walk(graph);
+	}

ERROR:SPACING: space required after that ',' (ctx:VxV)
#813: FILE: app/test/test_graph.c:677:
+			       " got %s
",node_names[i], node->name);
 			                  ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#834: FILE: app/test/test_graph.c:698:
+			       " got %s
",node_names[i], node->name);
 			                  ^

WARNING:MISSING_SPACE: break quoted strings at a space character
#856: FILE: app/test/test_graph.c:720:
+				printf("Obj count miss match for node = %s"
+				       "expected=%"PRId64" , got=%"PRId64"
",

WARNING:MISSING_SPACE: break quoted strings at a space character
#864: FILE: app/test/test_graph.c:728:
+				printf("func call miss match for node = %s"
+				       "expected= %"PRId64" , got=%"PRId64"
",

WARNING:BRACES: braces {} are not necessary for single statement blocks
#911: FILE: app/test/test_graph.c:775:
+		for (j = 0 ; j < MBUFF_SIZE; j++) {
+			mbuf_p[i][j] = &mbuf[i][j];
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#929: FILE: app/test/test_graph.c:793:
+	if (id == RTE_GRAPH_ID_INVALID) {
+		printf("Graph Destroy failed
");
+	}

total: 25 errors, 19 warnings, 837 lines checked


More information about the test-report mailing list