[dpdk-test-report] |WARNING| pw72938 [PATCH] net/pcap: support snaplen option to truncate packet

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72938

_coding style issues_


WARNING:TYPO_SPELLING: 'convinient' may be misspelled - perhaps 'convenient'?
#59: 
Introduced "snaplen=<length>" option. It is convinient to truncate

WARNING:LONG_LINE: line over 90 characters
#135: FILE: app/pdump/main.c:713:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#144: FILE: app/pdump/main.c:745:
+				snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#153: FILE: app/pdump/main.c:787:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#162: FILE: app/pdump/main.c:826:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))
+                       caplen = pp->snaplen;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pp->snaplen > 0'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'caplen > pp->snaplen'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))

ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+                       caplen = pp->snaplen;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+                       caplen = pp->snaplen;$

total: 2 errors, 8 warnings, 2 checks, 186 lines checked